Drop stale cppsdk/include references left by the vendored SDK removal - #204
Merged
Dimitris Gkanatsios (dgkanatsios) merged 1 commit intoAug 10, 2026
Conversation
#203 deleted cpp/cppsdk/include, but two build files still added it to their include path: - cpp/CMakeLists.txt passed cppsdk/include to target_include_directories - GSDK_CPP_UnitTests.vcxproj listed $(SolutionDir)cppsdk\include in the Debug and Release configurations Neither CMake nor MSBuild errors on a nonexistent -I path, so CI stayed green and nothing was broken. They are simply dead now. Also removes a duplicate $(SolutionDir)cppsdk from the same two AdditionalIncludeDirectories lines, which predates #203. All four unit test configurations now list the same three include paths. Reported by @amccalib in review on #203. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 6defd46f-b276-4683-bedd-6ba3aecdaa7f
Copilot started reviewing on behalf of
Dimitris Gkanatsios (dgkanatsios)
August 10, 2026 23:30
View session
There was a problem hiding this comment.
Pull request overview
Removes obsolete C++ SDK include paths left after the vendored SDK deletion.
Changes:
- Removes the stale CMake
cppsdk/includepath. - Cleans duplicate and stale Visual Studio unit-test include paths.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
cpp/CMakeLists.txt |
Removes the deleted include directory. |
cpp/unittests/GSDK_CPP_UnitTests.vcxproj |
Normalizes Release include paths. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Andy McCalib (amccalib)
approved these changes
Aug 10, 2026
Dimitris Gkanatsios (dgkanatsios)
deleted the
dev/digkanat/curl-deps-and-stale-includes
branch
August 10, 2026 23:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #203, addressing Andy McCalib (@amccalib)'s post-merge review nit.
#203 deleted
cpp/cppsdk/include/, but two build files still added it to their include path. Both are harmless — neither CMake nor MSBuild errors on a nonexistent-Ipath, which is why CI stayed green — they are just dead references now.Changes
Stale
cppsdk/includereferencescpp/CMakeLists.txt:31— dropped fromtarget_include_directories(GSDK_CPP PRIVATE ...)cpp/unittests/GSDK_CPP_UnitTests.vcxproj:99,119— dropped$(SolutionDir)cppsdk\includefrom the Debug and Release configurationsDuplicate include path (pre-existing, unrelated to #203)
The same two lines listed
$(SolutionDir)cppsdktwice:Now:
All four unit test configurations now list the same three include paths.
Verification
grep -r 'cppsdk[\\/]include'across the repo returns zero matchesCMakeLists.txton Linux;libGSDK_CPP_Linux.astill contains the expected 6 objectsGSDK_CPP_UnitTestsproject is the targetcpp-tests.ymlbuilds, so CI covers the vcxproj change onwindows-latestNot included
The bundled libcurl / OpenSSL dependency refresh is tracked separately in AB#63480313 and is assigned to its owner, so it is deliberately left out of this PR to avoid duplicating that work.