Remove threadPool.clear and instead provide means of pausing the threadPool#3321
Open
IntegratedQuantum wants to merge 1 commit into
Open
Remove threadPool.clear and instead provide means of pausing the threadPool#3321IntegratedQuantum wants to merge 1 commit into
IntegratedQuantum wants to merge 1 commit into
Conversation
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clear()is a brute-force solution, and it doesn't behave predictably when multiple threads are involved, as discovered in #3278 (comment)This is solved here by providing the ability to pause the threadpool momentarily (e.g. during cleanup). This means we do not have to worry about other tasks interfering with our cleanup logic
Then the cleanup phase can manually unschedule the tasks it doesn't need anymore (relying on the
isStillNeededfunction, which can be triggered by task reprioritization).fixes #3237
helps with #3278