Generalize Tooltip Rendering into one function, Also add 9 slice drawing function by SpellDigger · Pull Request #3276 · PixelGuys/Cubyz

SpellDigger · 2026-06-22T17:10:41Z

closes: #2312

Tooltip Example (i added backgroud texture)

buttons also now use bound9SliceImage to draw its outline instead of it being hardcoded
(they are drawn with slice scale 2 so it matches the original)

waiting to get slimed by quantum

SpellDigger · 2026-06-23T08:46:57Z

Made the tooltip texture less curved

Wunka · 2026-06-23T08:48:40Z

As I atleast think we need more tooltips (see #3242) I will move this to high priority so it gets soon looked at)

…_Imspdg into tooltip_render

IntegratedQuantum · 2026-06-27T18:41:05Z

+		boundSubImage(_destMin, _destMax - _destMin, _uvMin, _uvMax - _uvMin);
+	}
+
+	pub fn bound9SliceImage(_pos: Vec2f, _dim: Vec2f, _textureSize: Vec2f, _sliceCenter: Vec4f, _sliceScale: f32) void {


Please don't use underscores everywhere.
Also I'd suggest to rename _sliceCenter to edgeSize, also is there any reason this is a Vec4f instead of a simple float? In my opinion we shouldn't support asymmetrical texture sizes.

Also the existence of sliceScale is just odd. What does this mean? Why is it needed? It looks like it's hiding a bug.

the reason why _sliceCenter is a Vec4f is to allow for drawing more complex 9 slice images, having a float edgeSize locks away more complex textures from being drawn for which some sides and corners may have different proportions, if you really insist i can make it a single float

sliceScale is not a bug, idk what r u talking about but the whole purpose of sliceScale is quite literally what it says to scale up the size of the slices i think you are forgetting this is a general function for simplicity i can tell u goodluck drawing the buttons outline without it because u wont get the same result as the original i may remind u that the original code for drawing the buttons outline was also scaled x2

also the underscores for the u and v arguments are only there cuz zig compiler was screaming at me and refused to compile i could probably rename them to something else

But why is the button scaling the texture, but the tooltip isn't? Shouldn't everything have the same scale?

I'd prefer a single float, or 2 floats if you really want to have differences between x and y sizes. Anything else seems just weird and shouldn't be allowed in my opinion.

oki doki (i will make it a Vec2f)
the button is being scaled purely so it looks the same as the original buttons did, if you actually prefer a smaller outline i can set the scale to 1

But why doesn't the tooltip texture need to be scaled by the same amount?

tooltip has scale of 1? its just the buttons who have scale 2 since the original button code scaled them like that

In my opinion we should have the same pixel size for the tooltip outline as for the button outline

oki doki ur the boss i dont really care enough

IntegratedQuantum · 2026-06-27T18:41:58Z

-	}
+
+	textures.outlineTexture.bindTo(0);
+	graphics.draw.bound9SliceImage(self.pos, self.size, textures.outlineTextureSize, .{2, 2, 2, 2}, 2);


Previously this number was determined from the texture data. Allowing for arbitrary resolution textures. Here you have hardcoded it. Texture information should never be hardcoded.

im assuming you are talking about the slice edges here, well i sure can make the slice edges be determined from the texture

im doing the same to the tooltip background just incase

IntegratedQuantum · 2026-06-27T18:52:44Z

+	var renderpos = pos;
+	switch (alignment) {


Suggested change

var renderpos = pos;

switch (alignment) {

const renderpos = switch (alignment) {

IntegratedQuantum · 2026-06-27T18:53:04Z

+		.right => {
+			renderpos = pos + Vec2f{tooltipSliceCenter[0], 0};
+		},


Suggested change

.right => {

renderpos = pos + Vec2f{tooltipSliceCenter[0], 0};

},

.right => pos + Vec2f{tooltipSliceCenter[0], 0},

IntegratedQuantum · 2026-06-27T18:54:34Z

 const Label = @This();

-const fontSize: f32 = 16;
+pub const fontSize: f32 = 16;


No, this is not the place for a global font size.

Suggested change

pub const fontSize: f32 = 16;

const fontSize: f32 = 16;

IntegratedQuantum · 2026-06-27T18:56:41Z

Why is this slightly transparent? I cannot see through it at all.

honestly i dont know myself i just made it like that cuz it looks nicer, i can make it non transparent or more transparent if you like, i can see through it just fine but maybe its cuz of my monitor settings

I would suggest to just make it opaque.

IntegratedQuantum · 2026-06-27T18:58:13Z

-				const fontSize = 16;
-				var size = textBuffer.calculateLineBreaks(fontSize, 300);
+			if (hovered.inventory.getItem(hovered.itemSlot).getTooltip()) |tooltipContent| {
+				var label = GuiComponent.Label.init(Vec2f{0, 0}, 300, tooltipContent, .left);


I'd suggest to make a convenience function in tooltip.zig to render it as text.

SpellDigger · 2026-06-27T19:02:37Z

woah alot of stuff to do time to get to work

SpellDigger · 2026-06-28T12:59:22Z

Stuff changed:

funni quantum requests
tooltip background is now opaque
added renderFromText
tooltip now handles switching between alignments dynamically when the provided one leaves the screen
the dynamic corner thingy for buttons and tooltip textures
tooltip offset is now not based off texture but a constant (before the offset was gotten from cornerSize which created issues when tooltip texture was big)

IntegratedQuantum · 2026-06-28T13:04:17Z

+		boundSubImage(_destMin, _destMax - _destMin, _uvMin, _uvMax - _uvMin);
+	}
+
+	pub fn bound9SliceImage(_pos: Vec2f, _dim: Vec2f, _textureSize: Vec2f, _slices: Vec2f, _sliceScale: f32) void {


Again please remove all unnecessary underscores inside this and all other functions.

maybe list the unnecessary underscores so i actually know

I'm pretty sure most of them are unnecessary.
You only need underscores when you have name conflicts, and I'm pretty sure no similar names exist in scope.

IntegratedQuantum · 2026-06-28T13:08:06Z

 const ContinuousSlider = @import("components/ContinuousSlider.zig");
 const DiscreteSlider = @import("components/DiscreteSlider.zig");
 const TextInput = @import("components/TextInput.zig");
+const tooltip = @import("tooltip.zig");


Each file should be publicly imported in exactly one place so it's accessible from main.

im assuming you mean make it public

IntegratedQuantum · 2026-06-28T13:09:19Z

+	};
+}
+
+pub fn render(guicomponent: *GuiComponent, pos: Vec2f, alignment: graphics.TextBuffer.Alignment) void {


I don't think we should allow for alignment here. Tooltips should always be rendered in the same way in my opinion.

This would mean you can simplify the logic to a single if, like for the y coordinate.

i would argue otherwise incase someone would want to render 1 tooltip on the left and 1 tooltip on the right for whatever reason there could be, but since u say so

IntegratedQuantum · 2026-06-28T13:13:51Z

+	label.size = size;
+
+	var component = GuiComponent{.label = label};
+	defer component.deinit();


defer deinit should always be next to the init function, not 10 lines below it.

IntegratedQuantum · 2026-06-28T13:14:38Z

+	}
+	label.size = size;
+
+	var component = GuiComponent{.label = label};


use label.toComponent()

IntegratedQuantum · 2026-06-28T13:16:58Z

+
+	draw.bound9SliceImage(renderpos, size, @floatFromInt(tooltipTexture.size()), cornerSize, 1);
+
+	guicomponent.mutPos().* = renderpos + Vec2f{cornerSize[0], cornerSize[1]};


Instead of modifying the component, please use draw.setTranslation and draw.setClip to define the drawing area and pass an adjusted mouse position.

im not following what ur trying to make me do here

Check out VerticalList.render

im assuming you mean doing it like this?

const adjustedpos = renderpos + Vec2f{cornerSize[0], cornerSize[1]}; const oldTranslation = draw.setTranslation(adjustedpos); defer draw.restoreTranslation(oldTranslation); const oldClip = draw.setClip(guicomponent.size()); defer draw.restoreClip(oldClip); guicomponent.render(adjustedpos);

nvm i forgot to consider guicomponent would still use its internal position this might be more correct if we are going for mouse being inside the component

const adjustment = Vec2f{cornerSize[0], cornerSize[1]}; const oldTranslation = draw.setTranslation(renderpos + adjustment); defer draw.restoreTranslation(oldTranslation); const oldClip = draw.setClip(guicomponent.size()); defer draw.restoreClip(oldClip); guicomponent.render(guicomponent.pos() + adjustment);

SpellDigger added 5 commits June 22, 2026 18:48

Make it work

bf36f09

Cubyz Formatter

385854a

forgot mutpos exist

bf91a02

forgor

464c064

Rename tooltip.zig to Tooltip.zig (why didnt this change)

da5cf3f

Wunka added this to PRs to review Jun 23, 2026

Wunka moved this to Low Priority in PRs to review Jun 23, 2026

update tooltip background

7e4f8ed

Wunka moved this from Low Priority to High Priority in PRs to review Jun 23, 2026

SpellDigger added 5 commits June 23, 2026 12:18

Made Tooltip lowercase (its not a type or a component)

34c729d

Rename Tooltip.zig to tooltip.zig

e887ee8

Reduce unecessary variables in bound9SliceImage

e3e902f

Merge branch 'tooltip_render' of https://github.com/SpellDigger/Cubyz…

c00b0eb

…_Imspdg into tooltip_render

Merge branch 'PixelGuys:master' into tooltip_render

6b12ed6

IntegratedQuantum requested changes Jun 27, 2026

View reviewed changes

IntegratedQuantum moved this from High Priority to In review in PRs to review Jun 27, 2026

"Small" Modifications to tooltip rendering

4dd6279

merge repeating if statement

79b72fa

IntegratedQuantum requested changes Jun 28, 2026

View reviewed changes

SpellDigger added 2 commits June 28, 2026 16:18

quantum changes 2

1fd0df1

fixed adjustment not considering existing position

7d62c4e

	var renderpos = pos;
	switch (alignment) {
	const renderpos = switch (alignment) {


		draw.bound9SliceImage(renderpos, size, @floatFromInt(tooltipTexture.size()), cornerSize, 1);

		guicomponent.mutPos().* = renderpos + Vec2f{cornerSize[0], cornerSize[1]};

Uh oh!

Uh oh!

Conversation

SpellDigger commented Jun 22, 2026

Uh oh!

SpellDigger commented Jun 23, 2026

Uh oh!

Wunka commented Jun 23, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SpellDigger commented Jun 27, 2026

Uh oh!

SpellDigger commented Jun 28, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment