Cold Tall Mountain Variant#3017
Conversation
|
are these taller mountains? |
no, they are about the same height and will replace the current ones |
|
ah |
|
@careeoki if you could take a look at this at some point that would be appreciated. |
|
#3010 should be reviewed first, since this is like a variant of it |
|
Any suggestions for music for this variant, I think that it would be neat if the two different mountain types had two different tracks. |
|
I'll be updating this to include the height changes I've made on the other PR later today. |
|
@careeoki I've updated this PR to match the other one with height and other changes that should be parallel between this and the other one. |
There was a problem hiding this comment.
Alright, I know you're not gonna like what I'm gonna say, but for making snowy biomes like this I think we should wait for #1364
I really do not like how snowy-forest type biomes look when there's snow on the ground but the trees are completely bare. It just looks wrong.
I would be okay with it if there was just significantly less trees here.
There was a problem hiding this comment.
honestly I just put this in because I didn't want to put the tall mountain with trees on a cold mountain without them. I don't really care how many there are. I can change tree count or just switch it to generate on an already in game mountain.
There was a problem hiding this comment.
The tall mountain itself looks fine.
One thing I liked about your temperate tall mountain is how distinct the different layers were. Obviously you don't have as many blocks to work with here, but something simple like having big icicles on the higher slopes, similar to the peak biome, would be cool.
There was a problem hiding this comment.
I added some of the big icicles on the higher slopes, also thought it would be a good idea to add some ones made out of snow.
There was a problem hiding this comment.
Also, I think these biomes should be in cubyz:tall_mountain/cold/ rather than a seperate folder
There was a problem hiding this comment.
You should remove these changes as to not cause conflicts with #3098
|
Also you are failing the format check because you have spaces instead of tabs. |
|
I was thinking it might be a good idea to have separate music tracks for the different tall mountains so they feel more different. Do you know any good music for the biome? |
| .radius = 420, | ||
| .mountains = 150, | ||
| .maxSubBiomeCount = 1, | ||
| .stoneBlock = "cubyz:glacite/base", |
There was a problem hiding this comment.
You need to update to glacite/smooth here
There was a problem hiding this comment.
I've updated it now.
There was a problem hiding this comment.
oh sorry I forgot to sync changes
| @@ -0,0 +1,48 @@ | |||
| .{ | |||
| .properties = .{.mountain, .cold}, | |||
There was a problem hiding this comment.
Since this is a very snowy biome, I think it should be wet so it is placed closer to the other snowy biomes. (which are cold-wet)
There was a problem hiding this comment.
Everything has the wet property now.
careeoki
moved this from Waiting for artistic review
to In artistic review
in PRs to review
There was a problem hiding this comment.
Actually, one more thing, please add .pine and .snowy tags here
There was a problem hiding this comment.
Done(I did sync this time)
4 participants
This is another mountain update, adding a cold variant and splitting up the rather large PR that it was before.