Desert Shrublands#2967
Conversation
|
nice looks good |
|
Nice nice |
careeoki
left a comment
careeoki
left a comment
There was a problem hiding this comment.
I think this concept justifies a whole biome to itself, and not just a subbiome. The ones you see ingame are quite small and sad. I also think we should keep the regular desert mostly barren (other than the oasis) cause like, that's what deserts are like.
Ocotillo seems like a good choice for a new desert plant, though I will be creating a new model and texture.
Also you spelt it wrong, it's "ocotillo" not "octillo"
|
Actually, another desert subbiome would be fine, but the shrublands should definitely be its own biome |
|
I really would like to see this get merged |
|
Ah so you want it to be a bit larger? |
|
I would like to see it as a full biome. If you want to keep the subbiome as well, you can keep it at the size it already is at. |
sadly i am not sure why the subiomes are not working correctly yet for the biome
New ocotillo
wrong keyboard also fixed up the biome
|
new dessert shrubland biome added |
|
Cool |
There was a problem hiding this comment.
Please rename this subbiome now that there is a full biome version.
There was a problem hiding this comment.
Please move this in to the desert folder (desert/shrubland/base)
(and rename the subbiome as i said previously)
The biome creates a lot of these pools, causing all the plants to be underwater. You can instead use subbiomes like in the oasis or swampy biomes to prevent this. I also think there could be less water generally.
Actually, now that I'm looking at it, is this even intentional? Looks like the hills subbiome is causing it.
There was a problem hiding this comment.
Please make this more common, the biome needs more sparse areas
There was a problem hiding this comment.
I think this could be less common.
There was a problem hiding this comment.
please remove these now unused textures
There was a problem hiding this comment.
These air gaps shouldn't be happening. Did you put void blocks around your structures?
There was a problem hiding this comment.
I think these could use some variants where they directly on the ground, without a visible stem.
There was a problem hiding this comment.
These names are redundant, and also please count from 0: sbb/tree/baobab/shrub/0
| .parentBiomes = .{ | ||
| .{ | ||
| .id = "cubyz:desert/base", | ||
| .chance = 10, |
There was a problem hiding this comment.
Please make this less common, there are way more of them in a desert than I would like.
maybe .chance = 2
|
Heads-up, after #3006 foliage works a little differently. I made a PR on your branch for that |
|
anything happening on this since? |
Only allow sickle for ocotillo
|
nice |
|
testing this now |
hmm interesting how it interacts with water
|
|
yeah i ddint surround the sbb with void blocks |
|
yeah |
|
dose this pr need a rebase now that the latest dev is more advanced in pr's? |
|
it should still be functional what do you mean? |
|
ah was just curious |
|
updated and revamped |
|
that fixed it |
|
it looks good now |
careeoki
left a comment
careeoki
left a comment
There was a problem hiding this comment.
Overall I think it looks pretty good now. Please just fix these last few things
There was a problem hiding this comment.
Please do the reorganization I asked for last time:
desert_shrubland/base -> desert/shrubland/base
desert/shrubland/base -> desert/shrubbery/base (or another name if you have a better idea. just something to distinguish the subbiome from the full biome)
| .priority = 0.1, | ||
| }, | ||
| .{ | ||
| .id = "cubyz:simple_vegetation", |
There was a problem hiding this comment.
It would be nice if these were small flower_patches instead, so there could be 2-4 octillo next to eachother. (this applies to all the other ocotillo structures)
| .height = 1, | ||
| .height_variation = 0, | ||
| }, | ||
| .{ |
There was a problem hiding this comment.
These tiny ground patches look weird and messy. You should make them a little wider, and I would recommend using sand with pebbles on it instead for a more natural look.
| .smoothness = 0.6, | ||
| }, | ||
| .{ | ||
| .id = "cubyz:boulder", |
There was a problem hiding this comment.
Similarily, there are a lot of these 1-block boulders which look silly. Try to prevent them from being only 1 block.
now the arid_shrubland for the main biome
there's an error popup from the latest version of this pull request as i am testing this now
[latest.log](https://github.com/user-attachments/files/27592776/latest.log)
|
careeoki
moved this from Waiting for artistic review
to In artistic review
in PRs to review
|
anything happening here since? |
|
sorry for the delay updated to master |
careeoki
left a comment
careeoki
left a comment
There was a problem hiding this comment.
Other than this one last thing I think it looks good.
|
ok did that |
careeoki
left a comment
careeoki
left a comment
There was a problem hiding this comment.
This can finally move forwards
6 participants
a dessert shrublands that ocasionally shows up in the dessert
also adds the octillo plant