Move stb_image dependencies to build.zig.zon#14
Merged
Conversation
Also updates stb_image to v2.30
IntegratedQuantum
requested changes
May 11, 2026
|
|
||
| pub inline fn addHeaderOnlyLibs(b: *std.Build, c_lib: *std.Build.Step.Compile, flags: []const []const u8) void { | ||
| const cgltf = b.dependency("cgltf", .{}); | ||
| const stbImage = b.dependency("stb_image", .{}); |
Member
There was a problem hiding this comment.
The dependency should be called just stb, since it contains more than just image stuff.
Member
There was a problem hiding this comment.
Could you merge these into a single stb.c that contains all stb header only libs?
IntegratedQuantum
requested changes
May 11, 2026
| c_lib.installHeader(stb.path("stb_image_write.h"), "stb/stb_image_write.h"); | ||
| c_lib.installHeader(stb.path("stb_image.h"), "stb/stb_image.h"); | ||
|
|
||
| c_lib.root_module.addCSourceFiles(.{.files = &[_][]const u8{"lib/cgltf.c", "lib/stb_image.c", "lib/stb_image_write.c"}, .flags = flags}); |
Member
There was a problem hiding this comment.
The new file needs to be added here
Could you also test this in the game, to make sure there aren't more issues like this?
Contributor
Author
There was a problem hiding this comment.
Sorry, that was a premature push, should be ok now
IntegratedQuantum
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also updates stb_image to v2.30.
Progress towards PixelGuys/Cubyz#2346
Tested in windows x86.