Skip to content

Do not quit on Esc; instead, Esc triggers drill-down → aggregate#186

Merged
mike1858 merged 1 commit into
mainfrom
remove-esc-for-quit
Jun 13, 2026
Merged

Do not quit on Esc; instead, Esc triggers drill-down → aggregate#186
mike1858 merged 1 commit into
mainfrom
remove-esc-for-quit

Conversation

@mike1858

@mike1858 mike1858 commented Jun 13, 2026

Copy link
Copy Markdown
Member

Closes #185.

Summary by CodeRabbit

  • Bug Fixes
    • Quit now only triggers with q key; Esc no longer quits immediately
    • Esc key now switches back to aggregate view from session view and clears date-jump state
    • Updated help text to reflect new input behavior

@mike1858 mike1858 enabled auto-merge (squash) June 13, 2026 14:53
@coderabbitai

coderabbitai Bot commented Jun 13, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b5fd596b-2747-4a44-8e48-2c004c30e2a6

📥 Commits

Reviewing files that changed from the base of the PR and between 2d6efff and 27c9ea1.

📒 Files selected for processing (1)
  • src/tui.rs

📝 Walkthrough

Walkthrough

The TUI now separates quit and drill-down-exit behaviors. Only q exits the application; Esc no longer quits but instead exits period drill-down view back to aggregate mode. Help text is updated to reflect the new key bindings.

Changes

Esc Key Behavior Refactor

Layer / File(s) Summary
Core Esc and quit key handling
src/tui.rs
Event-loop quit condition now accepts only q; Esc is removed from the quit check with added comments. New Esc match arm in session view exits drill-down by switching to aggregate view, clearing date-jump state, and requesting redraw.
Help text updates
src/tui.rs
Aggregate-view help text and no-data screen help widget updated to show q to quit only, removing q/Esc references.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

A rabbit hops through tunnels deep,
But now with Esc can leap back up,
No quit by accident in sleep—
Just q will drain the final cup! 🐰✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title clearly describes the main change: preventing quit on Esc and making Esc return from drill-down to aggregate view, matching the primary objectives.
Linked Issues check ✅ Passed The code changes fully implement both requirements from issue #185: Esc no longer quits the app (only 'q' does), and Esc now returns from session/drill-down view to aggregate view.
Out of Scope Changes check ✅ Passed All changes in src/tui.rs are directly related to implementing the Esc key behavior requirements from issue #185. No unrelated modifications were introduced.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch remove-esc-for-quit

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mike1858 mike1858 merged commit 2fa5bd9 into main Jun 13, 2026
5 of 6 checks passed
@mike1858 mike1858 deleted the remove-esc-for-quit branch June 13, 2026 14:55
@mike1858 mike1858 mentioned this pull request Jun 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ESC key behavior

1 participant