Skip to content

fix(test): drop two KNOWN_EXT_GAPS entries #8375 made stale - #8385

Merged
proggeramlug merged 1 commit into
mainfrom
fix/zlib-ext-gaps-stale
Aug 18, 2026
Merged

fix(test): drop two KNOWN_EXT_GAPS entries #8375 made stale#8385
proggeramlug merged 1 commit into
mainfrom
fix/zlib-ext-gaps-stale

Conversation

@proggeramlug

@proggeramlug proggeramlug commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Summary

commands::compile::optimized_libs::tests::ext_zlib_covers_every_stdlib_symbol_the_flip_strips
is red on main at 1b61941bc:

these KNOWN_EXT_GAPS entries no longer describe reality — the symbol left
perry-stdlib or gained an ext implementation: ["js_zlib_crc32", "js_zlib_unzip_sync"].
Delete them; a list that outlives its entries stops being a ratchet.

#8375 ("add missing external zlib exports") implemented both symbols in
perry-ext-zlib but left their KNOWN_EXT_GAPS entries in place. The ratchet did
exactly what it is built to do — an allowlist entry that matches nothing fails — so
the fix is to delete the two entries, not to weaken the assertion.

Both symbols are now present in crates/perry-ext-zlib/src/lib.rs and
crates/perry-stdlib/src/zlib.rs, so they are covered on the flip path and the
missing assertion above stays satisfied. The three remaining entries under the same
comment (js_zlib_deflate_raw, js_zlib_inflate_raw, js_zlib_unzip) are still
genuine gaps and are untouched.

Validation

Verified against a clean main build at 1b61941bc:

  • before: test result: FAILED. 0 passed; 1 failed
  • after: test result: ok. 1 passed; 0 failed

Found while validating #8383 — the failure reproduced identically on unmodified main
at the same commit, so it is not that PR's.

Summary by CodeRabbit

  • Bug Fixes

    • Updated zlib compatibility tracking to reflect newly supported compression and decompression functionality.
    • Removed obsolete gap entries while retaining tracking for features that are still unavailable.
  • Documentation

    • Added a changelog entry documenting the updated zlib support.

@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 21042021-b21e-43a5-847e-9d91b21553ff

📥 Commits

Reviewing files that changed from the base of the PR and between 1b61941 and 87ebe93.

📒 Files selected for processing (2)
  • changelog.d/8385-zlib-ext-gaps-stale.md
  • crates/perry/src/commands/compile/optimized_libs/tests.rs

📝 Walkthrough

Walkthrough

The change removes two implemented zlib symbols from KNOWN_EXT_GAPS and adds a changelog entry.

Changes

Zlib gap cleanup

Layer / File(s) Summary
Update zlib gap allowlist
crates/perry/src/commands/compile/optimized_libs/tests.rs, changelog.d/8385-zlib-ext-gaps-stale.md
Removes js_zlib_crc32 and js_zlib_unzip_sync from KNOWN_EXT_GAPS. Documents that perry-ext-zlib implements these symbols.

Estimated code review effort: 1 (Trivial) | ~2 minutes

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/zlib-ext-gaps-stale

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@proggeramlug
proggeramlug merged commit ea900b4 into main Aug 18, 2026
30 of 33 checks passed
@proggeramlug
proggeramlug deleted the fix/zlib-ext-gaps-stale branch August 18, 2026 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant