fix(test): drop two KNOWN_EXT_GAPS entries #8375 made stale - #8385
Merged
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe change removes two implemented zlib symbols from ChangesZlib gap cleanup
Estimated code review effort: 1 (Trivial) | ~2 minutes ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
commands::compile::optimized_libs::tests::ext_zlib_covers_every_stdlib_symbol_the_flip_stripsis red on
mainat1b61941bc:#8375 ("add missing external zlib exports") implemented both symbols in
perry-ext-zlibbut left theirKNOWN_EXT_GAPSentries in place. The ratchet didexactly what it is built to do — an allowlist entry that matches nothing fails — so
the fix is to delete the two entries, not to weaken the assertion.
Both symbols are now present in
crates/perry-ext-zlib/src/lib.rsandcrates/perry-stdlib/src/zlib.rs, so they are covered on the flip path and themissingassertion above stays satisfied. The three remaining entries under the samecomment (
js_zlib_deflate_raw,js_zlib_inflate_raw,js_zlib_unzip) are stillgenuine gaps and are untouched.
Validation
Verified against a clean
mainbuild at1b61941bc:test result: FAILED. 0 passed; 1 failedtest result: ok. 1 passed; 0 failedFound while validating #8383 — the failure reproduced identically on unmodified
mainat the same commit, so it is not that PR's.
Summary by CodeRabbit
Bug Fixes
Documentation