Open
Conversation
improve: migrate RingBuffer to TypeScript and add accessors
Doing this to add support for .ts files on the index loading for later use too
convert voice module to typescript
Refactor HLS Module: TypeScript Migration and Functional Playlist Parser
improve: port playback processing modules to TypeScript
improve: port DES and Blowfish decrypters to TypeScript
i forgot to re-change it back to fmp4-buffered, this should reduce/fix the lag.
improve: migrate filters to TypeScript and enhance implementations
videoDetails still returned even without sts.
this also fixes audiomack seek crashing the mp4box
hoppefully reduced the amount of requests this takes to resolve a song, and added isrc extracting by default for searching songs.
entire youtube is now into typescript, with tsdocs, examples, params, etc. Fixed: infinite recovery requests after a track was skipped in youtube Improved: spotify auth handling, caching can make it be invalid, so added a retry mechanism to generate a valid one. Updated: typescript to version 6. Will do SABR soon, its not really an priority for me atm.
- Fix syntax errors in genius.ts, letrasmus.ts, and tidal.ts (corrupted code) - Remove all noExplicitAny warnings by using proper type narrowing - Add SourceResultWithData type for better discriminated union handling - Update JioSaavnSourceResult to include loadType: 'error' - Improve amazonmusic source with metadata caching and ISRC extraction - Add buildAmznHeaders helper to reduce code duplication - Use extractOrigin for proper URL handling across regions - Support H/M/S time format parsing in amazonmusic
Convert the Pandora source implementation from JavaScript to TypeScript, add dedicated Pandora typings, and fix strict typing issues in auth, error handling, and fallback track resolution paths. - add src/sources/pandora.ts fully typed implementation - add src/typings/sources/pandora.types.ts type definitions - remove legacy src/sources/pandora.js - fix nullable manager guards and typed exception handling
reduced array allocations during song resolving to improve performance improved URL validation and added normalization to avoid unnecessary requests reused existing extracted data whenever possible to reduce duplicate parsing (eg: thumbnail fetching from alt) fixed some misc bugs with specific urls and track matching
Convert Anghami source from JavaScript to TypeScript with strong typing, structured API payload models, and safer runtime narrowing. - add src/sources/anghami.ts with typed search/resolve/getTrackUrl - add src/typings/sources/anghami.types.ts for Anghami contracts - remove legacy src/sources/anghami.js - keep playlist buffered decoder behavior with typed protobuf reader
here some cool stuff i found out: PassThrough was always beign created even with HLSHandler, causing a big memory leak. Preferred playback is now DASH over HLS, since dash provides audio only tracks with a good quality/bitrate.
well, here some cool stuff that i found out and fixed too: fixed a potoken race condition, now it should prevent multiple requests with potokens. improved the stall detector to be more accurate during recovery and actually respect the downloadedMs. improved the handling for stream protection status 2, now it should not spam a lot of requests. i would consider this is actually stable to use atm, but not 100% sure about it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Write here about the changes you've made
Why
Write here why you think this should be merged
Checkmarks
Additional information
If you have any additional information, write it here