Fix active gem DPS sorting#1900
Closed
unrealdreamz wants to merge 1 commit into
Closed
Conversation
Contributor
|
Fixing this requires iterating across stat sets and have configs set correctly and even then it only applies for the first skill in a build so is largely useless |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1633.
Includes active replacement gems in the existing DPS sort estimate so active gems that change the selected skill's DPS are ranked by their actual impact instead of being left at the base build DPS.
Root Cause
GemSelectControl:UpdateSortCacheonly ran the DPS comparison for support gems that could support the displayed active skill, plus non-support gems with global effects. Ordinary active gems in the active-gem slot were still valid replacement candidates, but they were never sent throughCalcOutputWithThisGem, so they kept the base DPS value and missed the impact marker.Fix
+impact marker only for active replacement gems whose calculated DPS differs from the base DPS.Validation
git diff --check— passed, CRLF conversion warnings only.git diff --cached --check— passed, CRLF conversion warnings only.git show --check --stat --oneline HEAD— passed.I did not run Docker/Busted locally on this machine; the local test path for this repo is container-based and I avoided starting containers or external windows during this contribution pass.
Risk / Rollback
Risk is limited to the gem selector DPS-sort cache. The change reuses the existing calculator path already used for support/global-effect gem comparisons, and only broadens it for active-gem replacements in the active slot. Rollback is the single commit if it causes selector-performance or sorting regressions.