Skip to content

Add support for many Lineage mods#1828

Open
Peechey wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Peechey:feature/lineage-supports
Open

Add support for many Lineage mods#1828
Peechey wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Peechey:feature/lineage-supports

Conversation

@Peechey
Copy link
Copy Markdown
Contributor

@Peechey Peechey commented May 11, 2026

Description of the problem being solved:

Adding parsing for many Lineage supports:

  • Atziri's Allure
    • "Curses inflicted by Supported Skills ignore Curse limit"
  • Atziri's Impatience
    • "Supported Skills have 100% increased Cooldown Recovery"
  • Morgana's Tempest
    • "Supported Skills have 25% less area of effect"
    • "Supported Skills have 35% less damage"
    • "Supported Storm Skills have +1 to Limit"
  • Zerphi's Infamy
    • Supported Skills have 50% increased Area of Effect
    • Supported Skills deal 50% more Damage

I did not implement Glory for Zerphi's as it's already taken on by #1436.

There was a small bug related to AdditionalUses and skills that did not have an innate cooldown that I found when testing Thunderstorm - Hourglass - Morgana's Tempest. Fixed by passing the addedCooldown if the skill doesn't have an innate CD in these cases. The fix is in CalcOffence.

Steps taken to verify a working solution:

  • many

Link to a build that showcases this PR:

eNrdHNly2zjyOfoKlqpmX2ZjHdYVrz1TsmzHrrITreQku_syBZOQhDVIKABoWzM1_77dAEmROkElk8xsHhIK6G70he7GldOfX0LuPVGpmIjOqo2jetWjkS8CFk3Pqh_ur173qj__VDkdEj17PzmPGcee5k-VV6fmh8fpE-WAWPVCwqKx8B-pfitFPD-rdqqePyOS-JrKWwTrx1rciYCeVbWMadV7YvTZ_r65G74f3Vc9TeSU6o8pO_VfgK7PiVLvSAhgIxJNqax6RPk0CgbLjnciolVg6tXpkJMFlWNNtKfgr7NqH4QjU3rNNAxIeAzQjdbxUbNXrzeO6-1e_bha24l5HkulL0gIn2UpjOeUBhlS_ajRbHXrx71mr1XvtrdifSLSl4sBUfqehTSH3tuGMZT0cjKhvmZPdCCZHsxI5Ocwt-GVhb2LuWZzztAGCXxzG_z1GulGfSvxe6EJvxiOl7Ddo16n2-50Gp1mp9HdjSf0fvY_MT0752COA0ZB3JtpxDQ9EHkomBLRF8iXR91uoZhzmJxOsCOqqHwimhXZ2k5bhA8sOkh7AyF4IJ6jDK93VG-82TrpJCXvJ9abRyRgsbqjWlKVYbe2T4M7EpGBUEtv6LV3gQ6phDCiCxj1PQhj6guIPHmURv2o_eZNr9luNVqdlsOAm8lsHfmWTag7ZCmhEoSy3Bwmx-XYFa404cMYGkFEd4Mci5g7QuplaOxun3yf83CNztZUcEFflmDtHfTygFvhbiLtxFwertHubmfuSWAA2a-Ve8keYu2QZEy8u7weLmd796jb7jXrx80mZM2tehrOFor5hN-RFxbGIeSee_JIl5x12tv9eTrTEYTNbajbB71ikpbHGkA0PABrRoQqL90FkY8RVco1IUCAd8bASODAAtRA_gnC3kT-fhdFwA-RTJhxst-EjmDSY632wKkjxnKIJHS4FCl2qCmNkvEWbjq6pdSfvYXieERcpgAmiqWe6jvVirB5te4kukGtbUeEEkpCxM1Kau5CKamk8ZxJ5sSPhdwgewmcEuJfRlROF-MZozxwyFw56FRfAzJ3kR-sn8d28oLicKUcOY9a0laYZsuO9kRUPrF0d-vBQrup4IkE1HXJc0dhwVAKYyjFf3EZxsuhgRicl8c4cLQLOuGIJtCAkPmcMVwH6MtQxNLRiy2wk_HSLG8X4yMaxL5b_ZEtjs-58B9dxciwjLJLofa1Jv7jhQim5SxaCqPI3ziezyFg4UxwJYAFDOR9litsX7cdoN_DLHYKU1jruA-whHYeIKve3EdZQXGXBSuwlWFcgJ0HyMx5B1EyhHxjdo_uRC5lbQ1UeYxPMwgIHxRIOH5knOf2j4537B8pCi6zecG91SFizp02Dwyg4ybGUDyDvma4D6jKQUN1nCFsr9kljX5dONMvgDsNcBkFscTp5zzGKsamYc7jyUR5vggfiL4FpzqrVr0HaEu__Vgqan9ccRKG5IFxphd_9y65cQzCvU-U2MLeUsStRQ4_L4gmXpCs5D4SyUikG2Y_d6WxaRqV2eC9YlxTeQHjId8om6cokf4MWbginD9A9EO-lq3wCwc-rZltY_waiGjCph6xu5bmx5hqHMUwmLV4LDBDa6Y5NbmIxFwboFenN9E81l4Uhw9U4rLCi8x-cJhtVN4TRTiDyThb6FlohTdG8OkM4g2VGXIjRR7PQMgxBnC1Cx5CTIJAIxouVkPRDszjAiKGvSGs5nYgdItDJflPcG42xHdhvum0N3OZbGiXQMX4vx-rWWQVd40xZafet1-tjUa3OG5aDJZgFVW6n9X2GqdJ4tyBsyJdLifsQOrVO0WTJwWSkzP6AmbQfrUdr9lqr08VZbFnFe7-nsvtLnIsZ-RYx1FEcb0DgYkvdmJvmNC4n04lDYxKBiKGrEf5pCQPFwySLcR2_Rb-gtIZ9RU40RhAduUOXrxjzH4Yir0D9prFeYvnZzvt3-usu-b-ObCBT3v89EG5meh4fb7vH_V4c0za47ErDpirXl0EVGzK-PuJqRjAfpiad6FlYwU0FNGVkOF-o6_EvjQ_lolcxSVOkqtrWS40GdT-ws97SelHRp-TPDvWEpPur0KE_wZuOs2jZqvZ7bzpNRtdyMUz8YxlR-qHPlXpQSxi_Auq5lanftRtdY_fdLqtZqNhO27tCa9dg5_ehHMhtUdf8J8hkXpxVp0QriyvhqMkpePqLsvm-MOe5N4ESb2AG_VELvrLs1zsihhUrJEIkLl2vdV-gwfLCqqNha2PlSl3DHQErRHhiAWTRaMulgfHrfSUGCywyIMWTo8tM9Y8H0a35uPVTOu5OqnVnp-fj-ZEz8SEvkBJfQTlV20OSCDba4Wl9Wscs9aHP-fTvvljCNVSSqf2OFwl9seVgGQgmR3mFBaJdl887YCCUL6zomP59ZJ9s0in3wmtWoHYaQ31a5wDDYAfpvZXqSnwR1JcQQkn9VsaqvMFFOSpBwS2qoL2xNwReHy2n76CdIW7QCtngksC_4wJ1p7WyuhzsDC12PeLOcrQv71NnCJhK6nwEp1howdR-YHTIPUt0IDP44DeRMmiI-vAWwf9pZADwn2VXUfIdZg2Th5QtmpiAGDJM4ZEN0jY7OtfmWSqz3kMKdTU6lVTqAOfNxEYJXHRzzkpn2yFjFQK6AlJO8HtdLD9fyNzof6hPAsG_oxpzHC4KvfyekWeh0RKw4jFeMvFA-HN1JxTGiI3sJIjART4tRsNtquBvLWlNQqsFuk0Ejq1_YqCeEA0w2hysLKWJPYqbAn6fZWW56Os4u6EnJKIqHsawnTQ5dW2QmCD0hKIVGsJ4HdS2Qq75RX2HyrnM6Zu6ZT4i_LqKqBvUJbtzzwsmpBw8Z1UVWB1l6Ig4KOSNkZMO9xXDZiXnGb7B95rb1MQ826mkDKoN8CdCO-WhUz_FcKsVdafMMpmGzep3ssraY1EXkMbNob26gfr26-lIJQTPjbw-Kfx-o3-m99eK2-SPHbeGsX2b2cHlRmiyMGfxgZXUijtnUOluRZ3ljnYa9TrP3iDi9FmiyEJpHCAuVLUgq0ylr6TpZZM_T_UbN8qAruVbN_Yve9nMcgplYbVFjj4lrptk0XzmOWtmMfOW67Y_j28u8hBWQe_FrGc4sK-vEoy1A0OnfV9Qw9WORfOjf_XXm384ZO9xGLjG0_1MWUqZD7M8k0LDk-RSHnAplxU_wJLoT_cjs4roVU9WS0P5AHaWeLmdZLazTR_j4iYZ8vJm5PPdLvY7gSavVskvmsf2O4WIli6WRgraq9UQ30-F5FptpPAjISg-d27EWhTL068UX90WUn3sr3mtXdHfFq5gpmpQZVvJSV6BvUmlZWBJBNNgxMPOagMJZ2wlxPvN4kHmyf1o_bvtwJI3EQ-4CgaFPfHk4t57QPx-lHQ9_1YgovZm1DbCfWDYJXI_bO4JlHQqYzjye7B7W0gc8B2vBU6PSkda8kekztAG6Gt9c3dtNRFzJ5two81VKuSbMOeeM16xfSP6OcTr9urQCHEmc-0OvEald80maoTYhj83Q6tvICC0cZzSDgzz8paaXSbP2A8tAJ5mWmTblCP8potTwuv1Vjr_bHRaGBXqmzParvyY_Oo9QN2pLJ710x7VvRKozCgVaFndFj5sYNIRihPTDwCkduow7OubqbDnQjM4bjxzmbVM_rDSzDtdMIUII73QrT2QrT3QnT2QnTXIU5NUMimW-5GxO7JCUmNC4AFnOHDh9EtHiTYkyZY66lHDwhgnz0Cqe3GsAPkURr7UPphzKkuMcY15WEphJQpb_yM96uc8c6F0KoE_Ah81WuWQMCLPGEpDGuR8mOUsWG_JDzk3tLw5SU4LmM4yg_wj2ZZUzdK-VKw8NL7rqVMUZqt4wNELzs1ILc80fW5YUOQLSjwjJcEEHjwxPkTxbN7ZW92mfLC3OzCqscGrML1rOyGginXfrHNyQgWUkEGwofHl1dXl4P7m4-X2fUEpvxf8MYbvhdOUMb2ErOJhknFg7eUoQKLH5TtO6vi8bjpvIASi3GzguOczNVyR3-d2nV2iaFAy9DJ9TlQMpcpGKo0T-jyhUrMgMteB1LmmesaO5YXvFdvHws7EEpeJedJ2fSKT47tnX4HKgPzACNPBFvcRMG9GL6i3LTNRQAUHA-TsYxVG5Si8aAZqnc2YX4C42b19OZ0QTdJ1eJEwzwxLuInTQ7I9plwETttc9GqeaK8otWkzcW_qE8WReykyQE5exNSJJA1i8g8wHegdMlpn3E8FFix7DsRGWeHebMEcCB4B6EjuTtSJPgeL5JlPQ6Usgsbam32ZO0uujIP5wpqMi0uspjHYXlU2-I069najE3bXMxSeNhUCGaFHgdS6SX6PBHb5miGJN0WTJC0uUiSPi4qCJE2ukwUE3L7T4IF69FirfNLCZp3J1-BL3xZ8hXIZG-HnGiZunZltqRtB6J_0OaMagOV5W7IXiI44b6MAs67L6Ng6l8n7NFaJTJarT-2YGaPEFYHnlJ1MH72YOFgCvZZxcHo5g6nCzaGfvBYs8e1IfYvuxzTyGZaeKH5AjTiPCv2sLU5eBwmYpIpN0q6hWKyu2VfmK-HtqTDOZBsIwRp_Nq1XtxKKXszdU0Jx_9nRfAvI7j2xP5LiOGD13hOoiAl935TmV7aDEIroGne0Vzgu9ov1aG5q7xOKOPrtJYu6E7NhV-PzOc0Wl6ICqiCxQxJEjG-OBvPxHM_eEIfvgeTqMIV4XdC21urSDn5cVpb-w-m_gcPAo3K

After screenshot:

image image
image image
image image image image
image image image

@Peechey Peechey added the enhancement New feature, calculation, or mod label May 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature, calculation, or mod

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant