Conversation
This comment was marked as resolved.
This comment was marked as resolved.
- Fix nil-deref panic when secret list fails (return err instead of logging and continuing into raw.Items) - Replace Fatal+dead-return pattern with proper error propagation; per-secret failures no longer kill the whole process - Fix race between daemon start and certificate fetch by adopting the txcCertificateUpdater callback pattern (AddCertToWatchOpt + WithCertificateHandlerOption) so the Kubernetes secret is written only after the daemon actually delivers a cert, not via polling - One-shot semantics: WaitGroup per registered secret with 10-minute deadline; daemon stopped via defer after all updates complete - Remove unused appengine.MultiError fields; use errors.Join instead - Wrap secret Update in retry.RetryOnConflict to handle 409 conflicts - Skip Update when tls.crt/tls.key bytes are already identical to avoid unnecessary pod restarts - Log Warn (with secret name) when domains are skipped due to allowlist mismatch instead of silently continuing - areDomainsAllowed returns bool instead of error - parseDomainsAnnotation: lowercase, trim and deduplicate domains - Use namespace/name as the watch label for clarity - Fix 'tencent cloud' copy-paste error in KubernetesReplaceCertificate - CLI: drop bogus nil-checks on pflag pointers, remove pointless &emptyStr reassignment, fix StringP with empty short flag - Add defensive len(os.Args) guard in initCmd - model.go: use string fields instead of *string; add waitDeadline const - Add required RBAC comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.