Skip to content

Replace some AsyncCatcher calls, add new checks#13924

Open
Dueris wants to merge 9 commits into
PaperMC:mainfrom
Dueris:feat/extra-tick-checks
Open

Replace some AsyncCatcher calls, add new checks#13924
Dueris wants to merge 9 commits into
PaperMC:mainfrom
Dueris:feat/extra-tick-checks

Conversation

@Dueris

@Dueris Dueris commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

This adds a few new thread checks to Paper and replaces some AsyncCatcher calls with more specific checks using the TickThread class. This enforces against operations like opening/closing inventories async, or trying to kill an entity async for example.

@Dueris Dueris requested a review from a team as a code owner June 2, 2026 02:36
@github-project-automation github-project-automation Bot moved this to Awaiting review in Paper PR Queue Jun 2, 2026

@Toffikk Toffikk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, too often are plugins doing unsafe stuff and introducing race conditions

@Dueris Dueris force-pushed the feat/extra-tick-checks branch from ca4b9d0 to db89c99 Compare June 30, 2026 11:03
@Dueris

Dueris commented Jun 30, 2026

Copy link
Copy Markdown
Contributor Author

Rebased and fixed up for 26.2

@Dueris

This comment was marked as low quality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Awaiting review

Development

Successfully merging this pull request may close these issues.

4 participants