[WIP][Refactor] Use shield nomenclature instead of shielded#2077
Draft
Fuzzbawls wants to merge 3 commits intoPIVX-Project:masterfrom
Draft
[WIP][Refactor] Use shield nomenclature instead of shielded#2077Fuzzbawls wants to merge 3 commits intoPIVX-Project:masterfrom
Fuzzbawls wants to merge 3 commits intoPIVX-Project:masterfrom
Conversation
-BEGIN VERIFY SCRIPT- sed -i 's/shielded/shield/g' src/*.h src/*.cpp src/*/*.h src/*/*.cpp src/*/*/*.h src/*/*/*.cpp src/qt/forms/*.ui src/qt/pivx/forms/*.ui test/functional/*.py ; sed -i 's/Shielded/Shield/g' src/*.h src/*.cpp src/*/*.h src/*/*.cpp src/*/*/*.h src/*/*/*.cpp src/qt/forms/*.ui src/qt/pivx/forms/*.ui test/functional/*.py ; sed -i 's/SHIELDED/SHIELD/g' src/*.h src/*.cpp src/*/*.h src/*/*.cpp src/*/*/*.h src/*/*/*.cpp src/qt/forms/*.ui src/qt/pivx/forms/*.ui test/functional/*.py ; -END VERIFY SCRIPT-
Fuzzbawls
changed the title
furszy
added a commit
that referenced
this pull request
Dec 21, 2020
51db288 Only use one set of parentheses for optional arguments (Fuzzbawls) b38077a [RPC] Use "shield" nomenclature instead of "shielded" (Fuzzbawls) Pull request description: Alternative to #2077 that limits the scope to the RPC interface (and unit/functional tests that exercise the RPC interface) Drop the "ed" suffix in the RPC scope, changes commands like `getnewshieldedaddress` to `getnewshieldaddress`. Also in blockchain informational calls; `shielded_pool_value` and `shieldedsupply` become `shield_pool_value` and `shieldsupply` respectively. ACKs for top commit: random-zebra: utACK 51db288 furszy: utACK 51db288 Tree-SHA512: adc57ef2c9bfa3f06840c9fccca0570ed39724376828880c8d4249412ca700d2de71eac33c7af31163788bacc5e4649c2bd15de9415288a780488ead596ed702
Fuzzbawls
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes instances of
shielded/Shielded/SHIELDEDto drop theedsuffix, resulting in both shorter RPC command names and more consistency with our branding of the SHIELD protocol.The first commit does most of the changes, and is a scripted diff. The second commit is a basic file renaming, and the third cleans up the whitespace misalignments caused by the first commit.