Fix excessive reads of /proc/mounts - #620
Open
jenxie wants to merge 1 commit into
Open
Conversation
Signed-off-by: jenxie <32846807+jenxie@users.noreply.github.com> Co-authored-by: Gemini <noreply@google.com>
Author
|
Created a couple of file resources with: On Rocky Linux 9.8 node with SELinux enabled temporarily applied the changes locally to Before it resulted in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
Optimizes
read_mountsinPuppet::Util::SELinuxby caching the parsed mount data usingFile.mtime('/proc/mounts'). This avoids reading the file thousands of times during a single catalog application.Also includes a unit test to validate the caching behavior.
Fixes #619
Used Gemini to help debug the initial Ruby class variable state and structure the RSpec memoization test. All changes were manually verified and tested locally.
Checklist
I have:
Signed-off-byannotation to each of my commitsGenerated-byorAssisted-byannotations to each of my commits created with the help of an AI agent