Conversation
🤖 Augment PR SummarySummary: Optimizes
🤖 Was this summary useful? React with 👍 or 👎 |
| } | ||
|
|
||
| #if OPENSWIFTUI_LINK_COREUI | ||
| fileprivate func loadVectorInfo(from catalog: CUICatalog, idiom: Int) -> VectorInfo? { |
There was a problem hiding this comment.
With #if OPENSWIFTUI_LINK_COREUI moved inside the body, this file still references CoreUI types (e.g., CUICatalog, CUINamedVectorGlyph) in signatures/fields (loadVectorInfo, VectorInfo, cache subscripts), so non-CoreUI builds may still need those symbols available. Can you confirm this won’t break configurations where CoreUI isn’t importable/linkable?
Severity: medium
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
| _openSwiftUIPlatformUnimplementedFailure() | ||
| #endif | ||
| } | ||
|
|
There was a problem hiding this comment.
_openSwiftUIPlatformUnimplementedFailure() is the only statement in the #else branch of a non-Void function; this relies on it being -> Never for compilation/correctness when OPENSWIFTUI_LINK_COREUI is off (also applies to similar branches like symbolSizeScale).
Severity: medium
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #812 +/- ##
===========================================
+ Coverage 13.99% 27.39% +13.40%
===========================================
Files 624 659 +35
Lines 37809 42366 +4557
===========================================
+ Hits 5291 11606 +6315
+ Misses 32518 30760 -1758 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
No description provided.