Conversation
🤖 Augment PR SummarySummary: Adds optional direct linking to the private 🤖 Was this summary useful? React with 👍 or 👎 |
| #if canImport(Darwin) | ||
|
|
||
| #if OPENSWIFTUI_LINK_SFSYMBOLS | ||
| import SFSymbols |
There was a problem hiding this comment.
When OPENSWIFTUI_LINK_SFSYMBOLS is enabled this file no longer defines the SFSymbols shim type, but other files/tests reference SFSymbols.* without importing the SFSymbols module (e.g. Sources/OpenSwiftUICore/View/Image/NamedImage.swift, Tests/OpenSwiftUICoreTests/Util/SFSymbolsShimsTests.swift). That will likely become an unresolved identifier compile error in linking builds.
Severity: high
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
| .package(url: "https://github.com/OpenSwiftUIProject/OpenObservation", branch: "main"), | ||
| ] | ||
| if attributeGraphCondition || renderBoxCondition || linkCoreUI { | ||
| if attributeGraphCondition || renderBoxCondition || linkCoreUI || linkSFSymbols { |
There was a problem hiding this comment.
In the remote-deps branch, adding DarwinPrivateFrameworks is gated by attributeGraphCondition || renderBoxCondition || linkCoreUI || linkSFSymbols, but not linkBacklightServices (unlike the local-deps branch). This can break builds when LINK_COREUI=0 but LINK_BACKLIGHTSERVICES=1 by omitting the required package dependency.
Severity: medium
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #810 +/- ##
===========================================
- Coverage 27.41% 13.99% -13.43%
===========================================
Files 660 624 -36
Lines 42376 37809 -4567
===========================================
- Hits 11619 5290 -6329
- Misses 30757 32519 +1762 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary
LINK_SFSYMBOLSbuild flag andOPENSWIFTUI_LINK_SFSYMBOLSSwift define following the CoreUI patternimport SFSymbolswhen the flag is enabled, keeping the dlopen fallback for non-linking buildsTest plan
swift buildsucceeds withOPENSWIFTUI_USE_LOCAL_DEPS=1SFSymbolsShimsTestspass on Darwin