Skip to content

[NFC] Fix example build and identifier issue#809

Merged
Kyle-Ye merged 2 commits intomainfrom
k-branch-1
Mar 7, 2026
Merged

[NFC] Fix example build and identifier issue#809
Kyle-Ye merged 2 commits intomainfrom
k-branch-1

Conversation

@Kyle-Ye
Copy link
Collaborator

@Kyle-Ye Kyle-Ye commented Mar 7, 2026

No description provided.

@Kyle-Ye Kyle-Ye merged commit 7425dc9 into main Mar 7, 2026
7 of 8 checks passed
@Kyle-Ye Kyle-Ye deleted the k-branch-1 branch March 7, 2026 17:27
@github-actions github-actions bot added bug Something isn't working build issue P2 Low priority labels Mar 7, 2026
@augmentcode
Copy link

augmentcode bot commented Mar 7, 2026

🤖 Augment PR Summary

Summary: Fixes the Example app’s SwiftUI build by importing the system Observation module.
Also: Renames internal identifier strings (DisplayLink queue label + CGImage retain-key) to org.OpenSwiftUIProject.OpenSwiftUI.* to avoid using com.apple namespaces.

🤖 Was this summary useful? React with 👍 or 👎

Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

@codecov
Copy link

codecov bot commented Mar 7, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 27.42%. Comparing base (6029301) to head (e4bcfac).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ources/OpenSwiftUICore/View/Image/NamedImage.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #809       +/-   ##
===========================================
+ Coverage   13.98%   27.42%   +13.43%     
===========================================
  Files         624      660       +36     
  Lines       37809    42376     +4567     
===========================================
+ Hits         5288    11620     +6332     
+ Misses      32521    30756     -1765     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working build issue P2 Low priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant