Conversation
- Remove trivial equality/hash tests for BitmapKey, Key, Location, and Provider - Add BitmapKey tests for environment-based init and size class conversion - Add Location tests for fillVariant, mayContainSymbol, and findName logic - Fix resolveError test expecting wrong scale value (0 → 1.0)
🤖 Augment PR SummarySummary: This PR updates the image/symbol pipeline to build cleanly on Linux while improving Changes:
Technical Notes: Several new code paths are guarded behind 🤖 Was this summary useful? React with 👍 or 👎 |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #808 +/- ##
==========================================
- Coverage 27.57% 27.43% -0.15%
==========================================
Files 658 660 +2
Lines 41277 42376 +1099
==========================================
+ Hits 11383 11624 +241
- Misses 29894 30752 +858 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CUINamedVectorGlyph,SFSymbols,CGImage.width/height) by adding proper platform guardsNamedImageTests: remove trivial equality/hash tests, add meaningful tests forBitmapKeyenvironment init, size class conversion,fillVariant,findName, andmayContainSymbollogicresolveErrortest expectation (scale 0 → 1.0)Test plan
./Scripts/build.shswift test --filter OpenSwiftUICoreTestson macOS