Skip to content

Conversation

@matiasperrone-exo
Copy link
Contributor

@matiasperrone-exo matiasperrone-exo commented Jan 2, 2026

@matiasperrone-exo matiasperrone-exo added the documentation Improvements or additions to documentation label Jan 2, 2026
@matiasperrone-exo matiasperrone-exo self-assigned this Jan 2, 2026
@matiasperrone-exo matiasperrone-exo marked this pull request as ready for review January 5, 2026 20:05
@matiasperrone-exo matiasperrone-exo force-pushed the feature/openapi-documentation--oauth2summiteventsapicontroller branch from 08f38e3 to acf6356 Compare January 5, 2026 20:17
Copy link

@caseylocker caseylocker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matiasperrone-exo you have duplicate operationid values which are causing the doc generation to fail. Please fix and regenerate docs locally to verify before resubmitting.

While you're in there:
Line 84 & 133 in OAuth2SummitEventsApiControllerSchemas.php
Typo in description:
'RSVP external link, only if rsvp_template_id is not se'
Should be: '...is not set'

Thanks.

@matiasperrone-exo
Copy link
Contributor Author

Thanks @caseylocker for the comments. Now is ready to review again

Copy link

@caseylocker caseylocker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

openapi-generate check is failing as there is a class defined in 2 places. looks like a merge of pr 400 created duplicate a PaginatedTagsResponseSchema . Rebase and remove duplicate definition before submitting. Double check that the ci checks work as well.

@matiasperrone-exo matiasperrone-exo force-pushed the feature/openapi-documentation--oauth2summiteventsapicontroller branch from 1d696e9 to b26d9ce Compare January 8, 2026 19:27
@matiasperrone-exo
Copy link
Contributor Author

Thanks @caseylocker for catching that one.
The branch was rebase and now is ready to review again

Copy link

@caseylocker caseylocker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants