Open
Conversation
peb-adr
requested changes
Feb 13, 2026
Member
peb-adr
left a comment
There was a problem hiding this comment.
grep -r 'meta/dev'
lists the following additional places I expect need adjustment as well.
entrypoint.sh: meta/dev/scripts/wait-for-database.sh
dev/entrypoint.sh: meta/dev/scripts/wait-for-database.sh
openslides_backend/services/database/database_writer.py: with open("meta/dev/sql/schema_relational.sql") as f:
peb-adr
reviewed
Feb 13, 2026
Member
peb-adr
left a comment
There was a problem hiding this comment.
grep -r 'meta.dev' (regex dot matching any separating character)
lists even more.
entrypoint.sh: meta/dev/scripts/wait-for-database.sh
dev/entrypoint.sh: meta/dev/scripts/wait-for-database.sh
tests/system/action/base_generic.py: from meta.dev.src.generate_sql_schema import GenerateCodeBlocks, InternalHelper
tests/system/migrations/test_0100_init_reldb.py: from meta.dev.src.generate_sql_schema import GenerateCodeBlocks
tests/system/migrations/test_0100_init_reldb.py: "meta.dev.src.generate_sql_schema.GenerateCodeBlocks.generate_the_code",
tests/system/relations/setup.py: "meta.dev.src.helper_get_names.HelperGetNames.trigger_unique_list", []
openslides_backend/services/database/database_writer.py: with open("meta/dev/sql/schema_relational.sql") as f:
openslides_backend/migrations/migrations/0100_init_reldb.py: from meta.dev.src.helper_get_names import HelperGetNames # type: ignore # noqa
openslides_backend/migrations/migration_handler.py: from meta.dev.src.generate_sql_schema import GenerateCodeBlocks, HelperGetNames
cli/generate_models.py: from meta.dev.src.helper_get_names import (
Contributor
Author
These are all irrelevant files for this PR though. None of them reference the Makefile, but instead the various subfolders in /dev/ such as /scripts/ which remain unchanged |
Member
|
You're absolutely right, for this PR they are not relevant.. guess I mixed up the requirements we discussed |
peb-adr
approved these changes
Feb 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Path of Makefile in meta will change in this PR. Backend maketargets need to be adjusted for this