Skip to content

Adjust meta Makefile Path #3329

Open
Janmtbehrens wants to merge 1 commit intomainfrom
move-makefile-reldb
Open

Adjust meta Makefile Path #3329
Janmtbehrens wants to merge 1 commit intomainfrom
move-makefile-reldb

Conversation

@Janmtbehrens
Copy link
Contributor

Path of Makefile in meta will change in this PR. Backend maketargets need to be adjusted for this

Copy link
Member

@peb-adr peb-adr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

grep -r 'meta/dev'

lists the following additional places I expect need adjustment as well.

entrypoint.sh:                                            meta/dev/scripts/wait-for-database.sh
dev/entrypoint.sh:                                        meta/dev/scripts/wait-for-database.sh
openslides_backend/services/database/database_writer.py:  with open("meta/dev/sql/schema_relational.sql") as f:

@peb-adr peb-adr assigned Janmtbehrens and unassigned peb-adr Feb 13, 2026
Copy link
Member

@peb-adr peb-adr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

grep -r 'meta.dev' (regex dot matching any separating character)

lists even more.

entrypoint.sh:                                                meta/dev/scripts/wait-for-database.sh
dev/entrypoint.sh:                                            meta/dev/scripts/wait-for-database.sh
tests/system/action/base_generic.py:                          from meta.dev.src.generate_sql_schema import GenerateCodeBlocks, InternalHelper
tests/system/migrations/test_0100_init_reldb.py:              from meta.dev.src.generate_sql_schema import GenerateCodeBlocks
tests/system/migrations/test_0100_init_reldb.py:              "meta.dev.src.generate_sql_schema.GenerateCodeBlocks.generate_the_code",
tests/system/relations/setup.py:                              "meta.dev.src.helper_get_names.HelperGetNames.trigger_unique_list", []
openslides_backend/services/database/database_writer.py:      with open("meta/dev/sql/schema_relational.sql") as f:
openslides_backend/migrations/migrations/0100_init_reldb.py:  from meta.dev.src.helper_get_names import HelperGetNames  # type: ignore # noqa
openslides_backend/migrations/migration_handler.py:           from meta.dev.src.generate_sql_schema import GenerateCodeBlocks, HelperGetNames
cli/generate_models.py:                                       from meta.dev.src.helper_get_names import (

@Janmtbehrens
Copy link
Contributor Author

grep -r 'meta.dev' (regex dot matching any separating character)

lists even more.

entrypoint.sh:                                                meta/dev/scripts/wait-for-database.sh
dev/entrypoint.sh:                                            meta/dev/scripts/wait-for-database.sh
tests/system/action/base_generic.py:                          from meta.dev.src.generate_sql_schema import GenerateCodeBlocks, InternalHelper
tests/system/migrations/test_0100_init_reldb.py:              from meta.dev.src.generate_sql_schema import GenerateCodeBlocks
tests/system/migrations/test_0100_init_reldb.py:              "meta.dev.src.generate_sql_schema.GenerateCodeBlocks.generate_the_code",
tests/system/relations/setup.py:                              "meta.dev.src.helper_get_names.HelperGetNames.trigger_unique_list", []
openslides_backend/services/database/database_writer.py:      with open("meta/dev/sql/schema_relational.sql") as f:
openslides_backend/migrations/migrations/0100_init_reldb.py:  from meta.dev.src.helper_get_names import HelperGetNames  # type: ignore # noqa
openslides_backend/migrations/migration_handler.py:           from meta.dev.src.generate_sql_schema import GenerateCodeBlocks, HelperGetNames
cli/generate_models.py:                                       from meta.dev.src.helper_get_names import (

These are all irrelevant files for this PR though. None of them reference the Makefile, but instead the various subfolders in /dev/ such as /scripts/ which remain unchanged

@peb-adr
Copy link
Member

peb-adr commented Feb 15, 2026

You're absolutely right, for this PR they are not relevant.. guess I mixed up the requirements we discussed

@peb-adr peb-adr self-requested a review February 15, 2026 13:25
Base automatically changed from feature/relational-db to main February 20, 2026 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants