Add PQC signature support#658
Open
olszomal wants to merge 14 commits into
Open
Conversation
Member
|
Thanks for PR. I found few issues worth fixing before merge:
Also
|
Add support for ML-DSA, SLH-DSA, and FALCON keys in the PKCS#11 provider path. This includes key generation, key type detection from CKA_PARAMETER_SET, raw public key export, one-shot signing support, and FALCON verification through PKCS#11.
Add example programs for generating ML-DSA-87, SLH-DSA-256s, and FALCON-512 key pairs on PKCS#11 tokens.
Collaborator
Author
|
Thanks a lot for the review. Regarding point 1, I checked the That change explicitly uses "provider=default" when creating internal The same I fixed the remaining issues:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Related Issue
Fixes #606
Current Behavior
The PKCS#11 provider supports traditional key types and
EdDSA, but it does not handle post-quantum signature algorithms.New Behavior
ML-DSA,SLH-DSA, andFALCONkeys can be detected, generated, signed with, and verified where supported by the token and OpenSSL version.Scope of Changes
ML-DSA,SLH-DSA, andFALCONsigning and verification.Testing
Additional Notes
ML-DSAandSLH-DSA.FALCONis not supported by OpenSSL, so public-key operations forFALCONare performed through the PKCS#11 token instead of relying on the OpenSSL provider implementation.FALCONandSLH-DSAsupport could not be tested because no token supporting these mechanisms was available during development.License Declaration