Repository navigation
Refactor: Async getServerPPD() via authconn worker to prevent UI freezes - #482
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR introduces Prototype of a dedicated CUPS background worker integrated directly into
authconn.Connection. It safely moves the blockingpycupsoperationgetServerPPD()off the GTK main thread, resolving severe UI freezes during driverless PPD validation.Importantly, this is achieved while completely preserving the existing
authconnsemantics (authentication, polkit integration, retries, server-error handling, and operation bookkeeping).Key Changes
authconnWorker:_worker_loopand_execute_in_worker()inauthconn.py.cups.Connection.GLibevent loop while waiting, ensuring the UI (e.g., Cancel buttons, Spinners) remains fully responsive.newprinter.py):getServerPPD()is executing in the background.getattr(self, 'device', None) is Nonesafety checks immediately after async validation returns. If the wizard was destroyed/cancelled viaon_NPCancel(), the late worker result is safely abandoned, preventing hardAttributeError: 'NoneType' object has no attribute 'driverless'crashes.test_regression_getServerPPD_cancellation_real_v2_racetotest_newprinter.py.threading.Eventsynchronization to orchestrate the exact production race: it blocks the worker, triggers a genuineon_NPCancel()callback in the GTK loop, unblocks the worker, and verifies the late result is safely discarded without exceptions.Architecture Notes & Known Debt
GLib.MainLoop()and polling a shared queue using a 20msGLib.timeout_add. While functional, a future iteration should upgrade this to a proper asynchronouseventfdorpipe()wakeup mechanism viaGLib.io_add_watch.