Cover radiometric calibration in the micasense tests - #15
Merged
smathermather merged 1 commit intoAug 12, 2026
Merged
Conversation
The suite exercised multispectral band alignment but never --radiometric-calibration, leaving the reflectance conversion untested. Both modes are added since only camera+sun goes through the sun sensor irradiance estimate.
Contributor
|
Looks good and AFAICT is better than using Bürgewald as the micasense test dataset includes radiometric calibration coefficients. I did create a subset of Bürgewald for future testing in case it's useful, but Micasense is great for this purpose now. |
smathermather
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a test to cover the case in OpenDroneMap/ODM#2064 and the fix in OpenDroneMap/ODM#2066
The suite exercised multispectral band alignment but never
--radiometric-calibration, leaving the reflectance conversion untested. Both modes are added since onlycamera+sungoes through the sun sensor irradiance estimate.@smathermather the reported bug used a different dataset but it was 15GB or something. I believe the micasense dataset is also multispectral but I'm not entirely certain this makes sense. It does fail without the fix and pass with it, but that doesn't necessarily mean its correct.