[Rebase & FF] Adding "supervisor" feature flag and page table iterator#182
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
os-d
reviewed
Jun 5, 2026
makubacki
reviewed
Jun 6, 2026
makubacki
left a comment
makubacki
left a comment
Collaborator
There was a problem hiding this comment.
I'd like to review again after the page table iterator is added since that will be a relatively large change for the PR.
kuqin12
force-pushed
the
supv_bit
branch
2 times, most recently
from
6faf63b to
992acfa
Compare
kuqin12
changed the title
kuqin12
changed the title
kuqin12
force-pushed
the
supv_bit
branch
2 times, most recently
from
7c4a43b to
03e7877
Compare
os-d
reviewed
Jun 10, 2026
makubacki
reviewed
Jun 10, 2026
kuqin12
force-pushed
the
supv_bit
branch
4 times, most recently
from
e0a1693 to
be9db08
Compare
makubacki
approved these changes
Jun 12, 2026
cfernald
approved these changes
Jun 15, 2026
kuqin12
force-pushed
the
supv_bit
branch
3 times, most recently
from
8477b9c to
09526fe
Compare
cfernald
approved these changes
Jun 17, 2026
This change adds a paging iterator, which walks through the page table in a depth-first fashion and return the entry in `MappedRegion` struct. This provides the consumer a function to go over the page table instance for various needs. Signed-off-by: Kun Qin <kuqin@microsoft.com>
This change adds a "supervisor" feature, which will honor the supervisor mask definition and apply the appropriate supervisor bit in the page table entries (leaf level only). In addition, this feature also assumes the page table is marked as read only, which means paging protection needs to be disabled when the content is updated. Signed-off-by: Kun Qin <kuqin@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change adds the
mm_supvfeature, which will honor the supervisor mask definition and apply the appropriate supervisor bit in the page table entries (leaf level only).In addition, this feature also assumes the page table is marked as read only, which means paging protection needs to be disabled when the content is updated.
How This Was Tested
This was tested with QEMU Q35 platform + rust supervisor and booted to Windows desktop.
Integration Instructions
For modules that works with supervisor level paging, one needs to build with
mm_supvfeature flag.