Add RUSTSEC-2026-0173 exception#68
Conversation
9e479d1 to
71f3e64
Compare
Cargo Vet Audit Passed
|
`aquamarine` depends on `proc-macro-error2` which is now unmaintained. Remove it as it provides a minor QoL improvement. Mermaid diagrams are still present in the docs directory and Github supports rendered previews. Add an exception since defmt also depends on this crate.
71f3e64 to
e1cf677
Compare
There was a problem hiding this comment.
Pull request overview
This PR removes the aquamarine dependency and stops embedding rendered Mermaid diagrams into rustdoc, keeping the Mermaid source files under docs/ for GitHub-rendered previews. It also updates dependency/security configuration to account for the resulting dependency graph changes.
Changes:
- Remove
aquamarinefrom dependencies and from the lockfile. - Remove rustdoc attributes that embedded the Mermaid state machine diagram in
StateMachinedocs. - Add a
cargo-denyadvisory ignore entry forproc-macro-error2.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/ucsi/ppm/state_machine.rs | Removes rustdoc Mermaid embedding attributes for the PPM state machine docs. |
| deny.toml | Adds an ignore entry for RUSTSEC-2026-0173 (proc-macro-error2). |
| Cargo.toml | Drops the aquamarine dependency. |
| Cargo.lock | Removes aquamarine and its transitive deps from the resolved dependency set. |
kurtjd
left a comment
There was a problem hiding this comment.
If we still need the exception for defmt, does it make sense to keep aquamarine around anyway? Or do you foresee defmt moving off the dependency but not aquamarine?
It's more that |
aquamarinedepends onproc-macro-error2which is now unmaintained.Remove it as it provides a minor QoL improvement. Mermaid diagrams are
still present in the docs directory and Github supports rendered
previews. Add an exception since defmt also depends on this crate.