Repository navigation
fix(filter): exclude padding from semantic deduplication embeddings - #592
Merged
SunnyHaze merged 1 commit intoNov 18, 2026
Merged
Conversation
Collaborator
|
LGTM, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #591
Problem
Padding positions currently contribute to sentence embeddings. Adding a longer row can change the similarity between existing short texts and cause the operator to discard an otherwise retained row.
Change
Use attention-mask-weighted mean pooling in
get_text_embedding, retaining existing special tokens, normalization, thresholds and duplicate-selection behavior. No public API or dependency changes.Add offline CPU regressions using a locally saved tiny BERT and tokenizer. They cover batch invariance for short/empty strings, unchanged unpadded pooling, and public
run()decisions through both input-key forms, including duplicate removal and output labels.Validation
openpyxlis not installed).git diff --checkpasses.Related PR #571 also touches the embedding helper for batching, but still averages padding positions. This change only corrects pooling and may need a small rebase if that PR lands first.