Repository navigation
fix(generate): preserve outputs when chunked generation fails - #588
Merged
SunnyHaze merged 1 commit intoNov 16, 2026
Merged
Conversation
Collaborator
|
Looks good to me. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #587.
ChunkedPromptedGeneratorcurrently turns serving failures into empty successful output, overwriting previous results and publishing metadata. Propagate the original failure and validate the full response batch's container, count and string contents before opening any destination.Keep successful chunk order, output paths, prompts, schema and separator behavior. Assign output metadata by row position so duplicate DataFrame index labels do not overwrite each other's paths, and skip serving for a zero-row batch. Filesystem/storage errors still propagate; this does not make independent file writes transactional.
Validation: 19 offline tests passed (14 new regressions plus five existing output-path tests), using the real public operator/FileStorage and an offline serving double. The new suite fails on unmodified main: 8 failed, 6 passed. Coverage includes preserving previous outputs/cache on failure, late malformed responses, multi-row chunk alignment, list/tuple compatibility, custom/duplicate indices, options forwarding and empty input. New-test Black/isort checks and
git diff --checkpass.