Repository navigation
fix(storage): preserve streaming records and metadata - #586
Merged
SunnyHaze merged 2 commits intoNov 13, 2026
Merged
Conversation
Collaborator
|
LGTM, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #585.
Make
StreamBatchedFileStorageyield bounded DataFrame batches for JSON, Parquet and Pickle inputs instead of column-name strings, and expose matching top-level column metadata. Count logical CSV/JSONL records and reuse counts only while the current step and input-file identity are unchanged.The existing output write/flush paths are unchanged. Fallback formats still materialize the source before slicing; this does not introduce native streaming readers for those formats. Chunk readers close when iteration ends early, and symlink format detection follows the configured source filename.
Validation on Windows/Python 3.11.7, pandas 3.1.1 and PyArrow 26.0.1:
b9836cb, these tests produce 18 failures and 4 passing controls.git diff --checkpasses. No model-provider calls were used.