Conversation
- Upgrade PHPstan & fix issues - Add rector (no rules applied yet) - Fix phplint cache dir
- Cleanup composer.json by removing non-existant namespaces - Apply rectors: * ThisCallOnStaticMethodToStaticCallRector * NullToStrictStringFuncCallArgRector * RemoveUselessReturnTagRector * AnnotationToAttributeRector * RenameAttributeRector - User Deprecated: Since symfony/http-kernel 6.3: Parameter "container.dumper.inline_class_loader" is deprecated, use ".container.dumper.inline_class_loader" instead.
sass-migrator division assets/scss/**/*.scss Remove warnings like during compilation: Module Warning (from ./node_modules/sass-loader/dist/cjs.js): Deprecation Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0. Recommendation: math.div(18em, 14) or calc(18em / 14)
johanib
force-pushed
the
feature/upgrade
branch
from
8603c4c to
209c8e3
Compare
There was a problem hiding this comment.
While testing the changes in my dev environment, I found out quite some SASS parser deprecation warnings remain in the project. No blocker for me, just saying..
Also: while testing, I noticed your frontend-install modifications you made in the other projects is not included here. Leaving me with permission issues after running the frontend install task. Maybe add the following section here?
"frontend-install": [
"yarn install",
"yarn encore prod",
"./bin/console cache:clear",
"@fix-dev-permissions"
],
"fix-dev-permissions": [
"chown -R www-data:www-data /var/www/html/var/log",
"chown -R www-data:www-data /var/www/html/var/cache"
],
I'm happy to report that your changes result in a functioning demo gssp that can be used for registrations and authentications. So big up there 👍
johanib
force-pushed
the
feature/upgrade
branch
from
e289676 to
e7654bf
Compare
johanib
force-pushed
the
feature/upgrade
branch
4 times, most recently
from
f6ecc47 to
fe2d354
Compare
Added the fix-dev-permissions |
`js-yaml` was introduced as a resolution, then kept around. It's not needed.
Prior to this change, no copy-paste detection was performed as phpcpd was abanodoned. This change installs jscpd and checks the src dir.
The remaining ones are from `compass-mixins`
Prior to this change, consistent import style was not enforced. This change applies the phpcs rules for clean imports (no fqn, sorted, no unused).
johanib
force-pushed
the
feature/upgrade
branch
from
da6d448 to
e2d456f
Compare
3 participants
No description provided.