Repository navigation
feat(qt): rebuild first-run onboarding as guided one-decision steps - #1159
Merged
Merged
Conversation
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the six-step first-run wizard with Option B from the OpenNOW onboarding Paper file ("Guided, one decision per screen"): Mode → Picture → Boost (optional) → Ready, plus a required Network check that exists only where the macOS AWDL controller is supported.
Flow and layout
PageTabaccessibility, no labels in compact width). Content is one centred column, max 980 px, vertically centred on the window, with Back and the primary action directly under it.DesktopSettingsRowexpandable chevron plusDesktopSettingsDisclosure); the row summary reads e.g.HDR off · Codec Auto · 75 Mbps maximum. The REQUESTED badges, The Stage preview and the Bitrate limit card were dropped because they repeated the same values.DesktopOnboardingNetworkcard. Continue stays disabled ("Disable AWDL to continue") until AWDL is down or absent, exactly as before; Skip setup, Finish and a re-enable during save still route back to this step. On other platforms the step and its progress segment do not exist.OnboardingState.resetSettings) and moves on.What did not change
onboardingCompletedlast. Esc skips setup, Enter continues, Alt+←/→ navigate, Tab order follows the column.locales/en.jsononly. Strings the old screens alone used were removed; new ones were added with the existings_onboarding_<sha256[:10]>key scheme.Tests
cmake/Tests.cmakefollow the new order (layout0 1 3, resolution1, AWDL2, render/scroll0..3).revealFocusedControlclamps its margin so a tall control in a short viewport fits.tst_embeddedorchestration.cpphas no onboarding source-path fixtures, so it needed no change.ctest --output-on-failure460/460,npm run locales:checkOK,scripts/capture-qt-onboarding.shcaptures all steps including the newnetworkandnetwork-compact.Captures (left: app under xvfb with
--smoke-onboardingat 1600×900; right: Paper artboard)Compact 960×540 at 1.25×, Picture and Network check:

Not verified
The Network check ran on Linux with the injected AWDL controller, not on a real Mac with the admin prompt. No real GFN login was used.