fix(skillhub): disable installed remote skill installs#279
Closed
GatewayJ wants to merge 3 commits into
Closed
Conversation
Collaborator
Author
|
RussellLuo
reviewed
Jul 2, 2026
| remoteSkill: SkillSummary | null | undefined, | ||
| ): boolean { | ||
| const installedName = remoteSkillInstalledName(remoteSkill); | ||
| return hasSkillName(installedSkills, installedName); |
Collaborator
There was a problem hiding this comment.
Matching only by the local skill name seems too strong here: a same-named local skill does not necessarily mean this exact remote skill was installed before. Unless we persist a stronger remote identity such as source/remotePath on install, it may be safer to treat this as a name collision warning and let the user decide.
Revert the remote identity metadata follow-up and keep the original name-based disabled behavior. Disabled remote install buttons now continue to show the install label instead of switching to an installed label.
Collaborator
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
pnpm --dir web/app exec vitest run tests/models/skillhub.test.ts tests/api/skills.test.ts tests/hooks/useWorkspaceHubSelection.test.tsx tests/components/WorkspaceTabPanels.test.tsx -t "skill|AgenticHub|remote|official|extracts|matches|disables remote skill install actions|shows remote skills|refreshes local skills"pnpm --dir web/app typecheckpnpm --dir web/app lint(0 errors; existing warnings remain)git diff --checkImpact
Remote skill rows now show installed local skills as disabled
Installedbuttons in both light and dark themes, preventing duplicate install attempts and avoiding layout shift while an install is in progress.