[synackd]

Description

Fixes #190

Summary

CONTRIBUTING.md groups a subject's tests by suffix (<subject>_test.go, _errors_test.go, _boundary_test.go), but 48 subject/bucket pairs on main were split across two or three files. This PR moves each test into one file per subject and bucket and adds a check so the layout can't drift back.

This change only moves tests. Apart from 10 renames, every moved test, helper and fixture is byte-identical to main and stays in its package. The only new test is the check.

In cmd, each test file is named after the command path it covers, with one commit per family:

Family	Change
smd	Resource tests move from smd_test.go and smd_write*_test.go into smd_{group,group_member,iface,rfe,compep}*_test.go. smd_test.go keeps only TestSMDServiceStatus and TestSMDAdd_TrustsCACert, which spans the group and rfe add commands.
bss	New bss_boot_params, bss_boot_script and bss_hosts test files. TestBSSBootImageSet moves to bss_boot_image_test.go. bss_test.go keeps the commands directly under bss (dumpstate, history, service status, deprecated status).
boot, metadata	*_write*_test.go is folded into the family files. New boot_{bmc,config,node}_errors_test.go and metadata_group_test.go.
cloud-init	Group and node tests move into their files. New cloud_init_defaults*_test.go. cloud_init_test.go keeps only the service tests.
pcs	New pcs_status*_test.go. pcs_flags*_test.go is retired, and TestPCSTransitionStart_RequiresXname moves to pcs_transition_errors_test.go.
rcs	rcs*_test.go → rcs_console*_test.go (every test covers rcs console).
discover	discover static is the only command under discover, so discover_static*_test.go → discover*_test.go, and discover_static_flags_test.go is folded in.
root	Seven tests in config*_test.go that run version or smd group get, not config, move to root*_test.go (new root_boundary_test.go). They check how the root command loads config and resolves a command's base URI and token. The writeTempConfig helper they now share with the config tests and other families moves from config_test.go to testhelpers_test.go.

The _write files' fixtures (bootAddPayload, metadataTypes, addPayloadFor) moved with their users. Each moved file's file-level comment now describes what the file holds.

Outside cmd, tests of the same function that lived in different files were moved together:

• internal/cli: the CheckToken/HandleToken tests go to cli_test.go (removing cli_token_validation_test.go). The IOStreams tests and their readError/writeError stubs go to runtime_test.go, and TestIOStreams_Errors and its stubs go from cli_errors_test.go to runtime_errors_test.go. The InitConfig tests go from runtime_input_environment_test.go to runtime_test.go, the plain companion of runtime_errors_test.go, which holds the InitConfig error test.
• internal/configfile: the ReadConfigWithDefaults tests and their writeTemp/writeCfg helpers go to configfile_test.go (removing clusterdefaults_test.go and validate_test.go). clusterdefaults_errors_test.go → configfile_errors_test.go.
• pkg/client: TestUseCACert_FileFailures goes to client_errors_test.go. TestShowConsole_ReturnsConnectionCloseError goes to rcs/rcs_errors_test.go.
• pkg/config: the loadmerged_test.go tests go to config_test.go.

These tests are renamed:

• TestRuntime_EnvironmentIsolation → TestSetTokenFromEnv_PerRuntimeEnvironment.
• TestRuntimeInitConfig_DeclineCreate → TestInitConfig_DeclineCreate, so all the InitConfig tests share one subject.
• The six TestFile_* tests in pkg/config/transaction*_test.go → TestFileUpdate_*, since every File mutation goes through File.Update. TestFile_FailedUpdateLeavesStateUnchanged becomes TestFileUpdate_FailedBatchLeavesStateUnchanged, since TestFileUpdate_FailedUpdate… would repeat itself.
• TestConfig_NullValueHandling and TestConfig_IgnoreConfigSkipsConfigFile → TestRootCommand_*, since they moved to root_boundary_test.go and the other TestConfig boundary tests stay in config_boundary_test.go.

Tests

The last commit adds TestTestFiles_SubjectInOneFile to internal/conventions. It flags any subject (the part of a test name before the first _) that has tests of one bucket in more than one file. A file limited to some platforms, by a GOOS/GOARCH file-name suffix or a //go:build line with a platform tag (including unix), is compared only with files for the same platforms, so it can hold a subject's tests for those platforms. Other build tags, such as integration, don't exempt a file. New fixtures in testdata/violations check that it flags a split (widget_test.go), a file with a non-platform build tag (widget_tagged_test.go) and two files for one platform (widget_windows_test.go, widget_set_windows_test.go), and allows a file for another platform (widget_linux_test.go).

CONTRIBUTING.md now documents the one-file rule, the platform exception and the command-path naming in cmd.

Review notes

• The commits are meant to be reviewed one at a time. git diff --color-moved (or --color-moved=dimmed-zebra) shows that the moved code is unchanged.
• TestSMDDelete_* tables go to smd_errors_test.go, not commands_errors_test.go or per-resource tests as the issue suggested. They only cover smd, and other single-family tables (TestBootAdd_*, TestMetadataAdd_*, TestCloudInit_MalformedSuccessResponses) already sit in their family files. The issue's two options would either put a single-family table in the cross-family file or change test logic. CONTRIBUTING.md documents the resulting rule: tests that span several of a family's resources stay in the family file, error tables across families go to commands_errors_test.go, and other cross-family tests go in a file named after the behavior they check (prompts_test.go, service_status_test.go).
• The issue suggested renaming the generic subjects outside cmd. Only two were too broad to group (TestRuntime, TestFile), and TestRuntimeInitConfig duplicated TestInitConfig. The other split subjects named one specific function (CheckToken, HandleToken, ReadConfigWithDefaults, UseCACert, ShowConsole, LoadMerged), so they were moved together instead of renamed.
• Per-family error tests that repeat a row of a table in commands_errors_test.go are left as is. The issue marks that question as out of scope.

Manual testing

make lint reuse mod test   # passes; 0 lint issues, no go.mod/go.sum changes

# Same test count as main, plus TestTestFiles_SubjectInOneFile
go test ./... -list . | grep -c '^Test'   # one more on this branch than on main

The split-subject script from #190 now reports only the platform-specific files (sync_windows_test.go; owner*_test.go is //go:build unix) and the check's own fixtures:

internal/conventions/testdata/violations TestWidget plain widget_linux_test.go widget_more_test.go widget_set_windows_test.go widget_tagged_test.go widget_test.go widget_windows_test.go
pkg/config TestSyncParentDirectory plain sync_test.go sync_windows_test.go
pkg/config TestWriteFile errors owner_errors_test.go write_errors_test.go
pkg/config TestWriteFile plain owner_test.go write_test.go

Checklist

• My code follows the style guidelines of this project
• I have added/updated comments where needed
• I have added tests that prove my fix is effective or my feature works
• I have run make test (or equivalent) locally and all tests pass
• I have updated the relevant documentation (CLI examples, man pages, README, other docs, etc.) (CONTRIBUTING.md)
• DCO Sign-off: All commits are signed off (git commit -s) with my real name and email
• REUSE Compliance:
  • Each new/modified source file has SPDX copyright and license headers
  • Any non-commentable files include a <filename>.license sidecar
  • All referenced licenses are present in the LICENSES/ directory

Type of Change

• Bug fix
• New feature
• Breaking change
• Documentation update
• Dependency update
• Build system/CI

---

• I agree to follow the Code of Conduct.