Skip to content

feat(workflows): step 6, add runner input to long-running jobs - #47

Open
seantronsen wants to merge 1 commit into
seantronsen/feat/decouple-pr-cleanupfrom
seantronsen/feat/runner-selection
Open

seantronsen wants to merge 1 commit into
seantronsen/feat/decouple-pr-cleanupfrom
seantronsen/feat/runner-selection

Conversation

@seantronsen

@seantronsen seantronsen commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Description

Step 6 of the v4 stack (on top of #46). Adds a runner input (default ubuntu-slim) to the long-running jobs so callers can move them off slim's 1 CPU / 15-minute limit:

  • test-unit-go, lint-go (lint job), govulncheck, trivy-image-scan (scan job), lint-codegen-fabrica
  • README: runner in each one's optional overrides, plus one note on slim's limits.

Defaults are unchanged, so this isn't breaking.

Closes #42

Testbed: OpenCHAMI/github-actions-testbed#10.

Checklist

  • My code follows the style guidelines of this project
  • I have added/updated comments where needed
  • I have added tests that prove my fix is effective or my feature works
  • I have run make test (or equivalent) locally and all tests pass (actionlint, zizmor)
  • I have updated the relevant documentation (CLI examples, man pages, README, other docs, etc.)
  • DCO Sign-off: All commits are signed off (git commit -s) with my real name and email
  • REUSE Compliance:
    • Each new/modified source file has SPDX copyright and license headers
    • Any non-commentable files include a <filename>.license sidecar
    • All referenced licenses are present in the LICENSES/ directory

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Dependency update
  • Build system/CI

@seantronsen
seantronsen added this pull request to stack #40 October 13, 2026 20:09
@seantronsen seantronsen changed the title feat: add runner input to long-running jobs (closes #42) feat(workflows): step 6, add runner input to long-running jobs Oct 13, 2026
@seantronsen

Copy link
Copy Markdown
Contributor Author

See tests in OpenCHAMI/github-actions-testbed#10

@seantronsen
seantronsen marked this pull request as ready for review October 13, 2026 20:18
@seantronsen seantronsen added this to the v4.0.0 milestone Oct 13, 2026
@seantronsen seantronsen self-assigned this Oct 13, 2026

@synackd synackd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seantronsen
seantronsen force-pushed the seantronsen/feat/runner-selection branch from 94dcf26 to 058941c Compare October 19, 2026 16:21
@seantronsen

Copy link
Copy Markdown
Contributor Author

rebase incoming.

@seantronsen
seantronsen force-pushed the seantronsen/feat/runner-selection branch from 058941c to 60943fa Compare November 2, 2026 21:08
@seantronsen
seantronsen force-pushed the seantronsen/feat/runner-selection branch from 60943fa to c01b57a Compare November 2, 2026 21:34
@synackd

synackd commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Looks like commit signature is unverified.

@seantronsen

Copy link
Copy Markdown
Contributor Author

Looks like commit signature is unverified.

I will fix this tomorrow morning, but this is a good time to bring up the effects of squash merge.

If you look at the release-400 branch, you'll notice post squash the commits is unsigned (after all, our gpg keys are local).

@seantronsen
seantronsen force-pushed the seantronsen/feat/runner-selection branch from c01b57a to 916d0a3 Compare November 3, 2026 16:15
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
@seantronsen
seantronsen force-pushed the seantronsen/feat/runner-selection branch from 916d0a3 to 04eb718 Compare November 3, 2026 16:32
@seantronsen

Copy link
Copy Markdown
Contributor Author

fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants