658 autonomic input validation - #3765
Open
calmonroe wants to merge 15 commits into
Open
Conversation
Contributor
Author
|
Enterprise Playwright test run here: https://github.com/OpenC3/cosmos-enterprise/actions/runs/32767849978/job/97598253784 |
…penC3/cosmos into 658-autonomic-input-validation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3765 +/- ##
==========================================
+ Coverage 79.09% 79.12% +0.02%
==========================================
Files 894 894
Lines 66865 66876 +11
Branches 2551 2599 +48
==========================================
+ Hits 52890 52915 +25
+ Misses 13313 13300 -13
+ Partials 662 661 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ryan-pratt
reviewed
Aug 25, 2026
ryan-pratt
reviewed
Aug 25, 2026
|
ryan-pratt
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes https://github.com/OpenC3/cosmos-enterprise/issues/658
What changed
Added item validation to the autonomic autonomic_trigger_create method to ensure the item exists prior to creation. If the item does not exist, the user will get the following error:
RuntimeError : autonomic_trigger_create failed due to RuntimeError : autonomic_trigger_create error: invalid operand: Item 'INST HEALTH_STATUS DNE' does not exist (TargetModel)
Why it changed
Previously a user could create an autonomic trigger for an item that doesn't exist, which could delay the user being aware of potential typos or issues with the trigger
Testing strategy
Added unit testing to ensure proper coverage
Tested functionality by going into Script Runner and attempting to create a trigger for an item that doesn't exist