fix(script-runner): validate suiteRunner values as identifiers - #3755
Open
jmthomas wants to merge 3 commits into
Open
fix(script-runner): validate suiteRunner values as identifiers#3755jmthomas wants to merge 3 commits into
jmthomas wants to merge 3 commits into
Conversation
The suite, group, script, and method values are interpolated into the Ruby/Python snippet the running script evaluates, so unvalidated input allowed arbitrary code execution and bypassed the script approval gate enforced in scripts_controller#run (CWE-94 / CWE-863). Reject anything that isn't a bare class/method name in SuiteRunner build_options (both languages, covering the GUI and openc3cli paths) and at the controller so bad requests return 400 instead of starting a run. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3755 +/- ##
==========================================
+ Coverage 79.15% 79.16% +0.01%
==========================================
Files 894 894
Lines 66866 66916 +50
Branches 2552 2600 +48
==========================================
+ Hits 52925 52976 +51
+ Misses 13280 13276 -4
- Partials 661 664 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
clayandgen
reviewed
Aug 21, 2026
clayandgen
left a comment
clayandgen
left a comment
Contributor
There was a problem hiding this comment.
I guess it finds nested ifs as a major code smell... logic looks good, will approve once that's resolved
EmilyRagan
reviewed
Aug 25, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The suite, group, script, and method values are interpolated into the Ruby/Python snippet the running script evaluates, so unvalidated input allowed arbitrary code execution and bypassed the script approval gate enforced in scripts_controller#run (CWE-94 / CWE-863).
Reject anything that isn't a bare class/method name in SuiteRunner build_options (both languages, covering the GUI and openc3cli paths) and at the controller so bad requests return 400 instead of starting a run.
🤖 Generated with Claude Code