gate cmd_tlm overlay writes at every writer - #3731
Open
jmthomas wants to merge 3 commits into
Open
Conversation
scripts#create wrote an arbitrary targets_modified path at the script_edit tier, so a non-admin could place a cmd_tlm definition that PacketConfig evaluates as code (GENERIC_*_CONVERSION) in the decom microservices. The existing gates only covered the presigned upload and the Table writers. Extract the canonical-path and cmd_tlm rules into OpenC3::ConfigOverlay and call it from all three writers: storage_controller, tables_controller, and scripts#create/destroy. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
jmthomas
requested review from
ryanmelt
and
a lite review from Copilot
and removed request for
Copilot
August 19, 2026 18:17
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3731 +/- ##
==========================================
- Coverage 80.02% 79.99% -0.03%
==========================================
Files 885 886 +1
Lines 65382 65401 +19
Branches 2543 2543
==========================================
- Hits 52322 52319 -3
- Misses 12396 12417 +21
- Partials 664 665 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jmthomas
changed the title
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent a non-admin from writing the cmd_tlm directory when creating scripts.
Extract the canonical-path and cmd_tlm rules into OpenC3::ConfigOverlay and call it from all three writers: storage_controller, tables_controller, and scripts#create/destroy.
🤖 Generated with Claude Code