Skip to content

fix: build run use current uid/gid#1675

Merged
dengbo11 merged 1 commit into
OpenAtom-Linyaps:masterfrom
reddevillg:build_run
Jun 12, 2026
Merged

fix: build run use current uid/gid#1675
dengbo11 merged 1 commit into
OpenAtom-Linyaps:masterfrom
reddevillg:build_run

Conversation

@reddevillg

Copy link
Copy Markdown
Collaborator

No description provided.

Signed-off-by: reddevillg <reddevillg@gmail.com>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates apps/ll-builder/src/main.cpp to retrieve and pass the effective user ID (UID) and group ID (GID) to runInNamespace when buildRun is parsed. The review feedback correctly identifies a type safety issue where gid is declared as std::optional<uid_t> instead of std::optional<gid_t>, which should be resolved.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

return -1;
}

std::optional<uid_t> uid, gid;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Declaring std::optional<uid_t> uid, gid; makes both uid and gid have the type std::optional<uid_t>. However, gid should be of type std::optional<gid_t>. While uid_t and gid_t are often represented by the same underlying integer type on Linux, they are distinct types, and using the wrong type can lead to compilation errors or type-safety violations.

        std::optional<uid_t> uid;
        std::optional<gid_t> gid;

@codecov

codecov Bot commented Jun 12, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
apps/ll-builder/src/main.cpp 0.00% 5 Missing ⚠️
Files with missing lines Coverage Δ
apps/ll-builder/src/main.cpp 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dengbo11 dengbo11 merged commit 8997559 into OpenAtom-Linyaps:master Jun 12, 2026
15 of 16 checks passed
@reddevillg reddevillg deleted the build_run branch June 12, 2026 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants