fix: build run use current uid/gid#1675
Conversation
Signed-off-by: reddevillg <reddevillg@gmail.com>
There was a problem hiding this comment.
Code Review
This pull request updates apps/ll-builder/src/main.cpp to retrieve and pass the effective user ID (UID) and group ID (GID) to runInNamespace when buildRun is parsed. The review feedback correctly identifies a type safety issue where gid is declared as std::optional<uid_t> instead of std::optional<gid_t>, which should be resolved.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| return -1; | ||
| } | ||
|
|
||
| std::optional<uid_t> uid, gid; |
There was a problem hiding this comment.
Declaring std::optional<uid_t> uid, gid; makes both uid and gid have the type std::optional<uid_t>. However, gid should be of type std::optional<gid_t>. While uid_t and gid_t are often represented by the same underlying integer type on Linux, they are distinct types, and using the wrong type can lead to compilation errors or type-safety violations.
std::optional<uid_t> uid;
std::optional<gid_t> gid;
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
No description provided.