Repository navigation
typescript-axios: support TypeScript 6 - #25148
Conversation
Add a regression assertion for the generated TypeScript dependency range.
There was a problem hiding this comment.
All reported issues were addressed across 2 files
Reply to a comment to ask cubic a question or push back. It learns from your replies.
Re-trigger cubic
Remove the explicit node10 moduleResolution override from generated ES6 tsconfig files. TypeScript 6 deprecates that setting; omitting it preserves the compiler default while keeping generated clients compatible.
Generate an ES6 client in the TypeScript 6 compatibility regression test and assert its tsconfig does not specify the deprecated node10 resolution option.
|
thanks for the PR cc @TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02) @davidgamero (2022/03) @mkusaka (2022/04) @joscha (2024/10) @KannaKim (2026/07) |
Remove 'moduleResolution' option from tsconfig.json
|
please update the samples to fix https://github.com/OpenAPITools/openapi-generator/actions/runs/37507777157/job/112613481427?pr=25148 |
Update with-complex-headers generated package.json to match the TypeScript Axios template range.
Update the with-npm-version-and-separate-models-and-api generated sample.
Update the with-npm-version generated sample to match the current TypeScript range.
|
Updated the three generated TypeScript Axios samples flagged by the Samples up-to-date check (with-complex-headers, with-npm-version-and-separate-models-and-api, and with-npm-version) to include ^6.0 in their TypeScript devDependency ranges. The changes match the expected generated output. Thanks! |
Summary
typescript-axiosdevelopment dependency range.package.json.Closes #24830.
Validation
git diff --checkpassed../bin/generate-samples.sh ./bin/configs/typescript-axios-echo-api.yaml ./bin/configs/typescript-axios-es6-target.yaml; both generators succeeded../mvnw -pl modules/openapi-generator -am -Dtest=TypeScriptAxiosClientCodegenTest -Dsurefire.failIfNoSpecifiedTests=false test(15 tests, 0 failures). The latest PR workflow runs are awaiting maintainer approval.Prepared with AI assistance.
Summary by cubic
Makes the
typescript-axiosgenerated clients work with TypeScript 6. Closes #24830.^4.0 || ^5.0 || ^6.0.moduleResolution: nodesetting from generated ES6tsconfigfiles so TypeScript 6 can use its compiler default.Written for commit 5aa3707. Summary will update on new commits.