chore: password-reset follow-ups - #439
Merged
Merged
Conversation
User-facing "Reset a forgotten password" section, explicitly out of scope for the implementation PR #436. Every claim checked against the shipped routes and frontend; sphinx -n -E build clean. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XXfamqoPKiuxVyJYxV7Y78
Closes #437 — with the mechanism corrected: the issue's leftover-rows story does not reproduce on any repo-created schema, because the user_entitlements FK has carried ON DELETE CASCADE since its first commit (e5daadd), so the fixture's DELETE FROM users already cascade-clears it. 34/34 live postgres:18 runs green on fresh and reused databases, with and without this change. The explicit wipe still lands as hardening: the fixture already wipes three other equally-cascading child tables, and a long-lived dev database mutated by a review branch's divergent DDL is a real local hazard. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XXfamqoPKiuxVyJYxV7Y78
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-ups to #436. Closes #437.
docs/source/lab/accounts.rst— "Reset a forgotten password" section (explicitly out of feat(auth): password reset via emailed code #436's scope). Every claim verified against the shipped routes and frontend;sphinx-build -n -Eclean, section renders.temp_postgres_store— wipesuser_entitlementsalongside the other child tables. Note: test: temp_postgres_store fixture never clears user_entitlements #437's stated mechanism does not reproduce — the FK has beenON DELETE CASCADEsince the table's first commit (e5daadda), so a repo-created schema cannot strand rows, and 34/34 live postgres:18 runs are green on fresh and reused DBs with or without the fix. The wipe lands as hardening: the fixture already explicitly wipes three equally-cascading child tables, and a long-lived local dev DB mutated by a review branch's divergent DDL is a real hazard.🤖 Generated with Claude Code
https://claude.ai/code/session_01XXfamqoPKiuxVyJYxV7Y78