fix: parse Android notification raw payload - #58
Open
fadi-george wants to merge 1 commit into
Open
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
nan-li
approved these changes
Sep 4, 2026
nan-li
left a comment
There was a problem hiding this comment.
Looks good. Two small things, neither blocking:
- Each item in
groupedNotificationsstill hasrawPayloadas a string, sinceOSNotificationcopies that array without parsing it. This is pre-existing, but it may be worth fixing here or in a follow-up. - Since this wasn't device-tested, consider doing a tap on the Android demo and confirm
rawPayloadin the click handler
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Parse Android notification click
rawPayloadvalues into objects consistently with foreground notification events.Details
Motivation
Android sends
rawPayloadacross the Capacitor bridge as a JSON string. Click events previously forwarded the native notification directly, bypassingOSNotificationparsing and exposing a string despite the publicobjecttype.Scope
Normalizes click-event notifications through
OSNotification. Foreground notification behavior and public APIs are unchanged.Testing
Unit testing
Added coverage verifying click notifications are
OSNotificationinstances and string payloads are parsed into objects.Manual testing
Not manually device-tested. Automated source checks, 225 tests, and the package build pass.
Affected code checklist
Checklist
Overview
Testing
Final pass
Made with Cursor