Skip to content

fix: [SDK-5158] serialize grouped notifications on Android - #57

Merged
fadi-george merged 4 commits into
mainfrom
fadi/sdk-5158
Sep 2, 2026
Merged

fix: [SDK-5158] serialize grouped notifications on Android#57
fadi-george merged 4 commits into
mainfrom
fadi/sdk-5158

Conversation

@fadi-george

@fadi-george fadi-george commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Description

One Line Summary

Serialize Android groupedNotifications as structured notification objects instead of string values.

Details

Motivation

Notification click payloads passed the native List<INotification> directly through the Capacitor bridge, causing grouped notifications to be stringified. This recursively serializes each grouped notification, matching the React Native SDK behavior.

Scope

Affects Android notification serialization for click and foreground notification events. No public API changes.

Testing

Unit testing

No native serializer test was added because this repository does not currently have Android bridge unit-test coverage.

Manual testing

  • Add console.log('Event:', e); to handleNotificationClick.
  • On main, run vp run dev:android and send two grouped notifications.
  • Click the grouped notification and observe that groupedNotifications is stringified in the logged notification object.
  • Repeat on this PR branch and verify that groupedNotifications is logged as an array of notification objects instead of a string.

Automated validation:

  • vp run lint
  • vp test run (224 tests passed)
  • vp run build

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
  • No public API changes

Testing

  • Test coverage status is explained
  • All automated tests pass
  • Device-testing steps are documented

Final pass

  • Code is as readable as possible
  • I have reviewed this PR myself

@fadi-george
fadi-george requested a review from a team September 2, 2026 18:08

@sherwinski sherwinski left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment

@fadi-george
fadi-george merged commit 381e016 into main Sep 2, 2026
5 checks passed
@fadi-george
fadi-george deleted the fadi/sdk-5158 branch September 2, 2026 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants