Skip to content

chore: complete TypeScript wrapper cleanup - #54

Merged
fadi-george merged 8 commits into
mainfrom
fadi/SDK-5125
Sep 2, 2026
Merged

chore: complete TypeScript wrapper cleanup#54
fadi-george merged 8 commits into
mainfrom
fadi/SDK-5125

Conversation

@onesignal-deploy

Copy link
Copy Markdown
Collaborator

Description

One Line Summary

Combine the Capacitor TypeScript wrapper release, demo validation, response handling, tooltip, cache, and lifecycle cleanup.

Details

Motivation

Linear: SDK-5125, SDK-5118, SDK-5122, SDK-5123, SDK-5124.

This consolidates all applicable Capacitor work from the React Native reference audits into one repository branch and PR.

Scope

  • Forward target_branch to the shared release preparation workflow while preserving the main default.
  • Share in-flight tooltip initialization, cache only successful parsing, and permit later manual retries after non-fatal failures.
  • Reject malformed or ambiguous notification success bodies; retry only recognized subscription-indexing failures across all existing demo send paths.
  • Reject missing/non-finite outcome values and preserve special dictionary keys such as __proto__.
  • Keep the stable demo tarball when packed bytes are unchanged and key each demo install stamp to the tarball hash.
  • Guard async demo startup snapshots against newer subscription, permission, and user events.
  • Do not port Metro/env cache behavior. Header-title and inline-control remount patterns are absent from these web demos; custom event JSON was already object-only.

References: OneSignal/react-native-onesignal#1981, #1982, #1983, #1984, #1985, #1988.

Testing

  • vp test run: 14 files and 224 tests pass; coverage thresholds pass.
  • Focused vp check: all 18 changed TypeScript/TSX files pass formatting, lint, and type checking.
  • Release workflow formatting and bash -n examples/setup.sh: pass.
  • Production web builds pass for demo, demo_pods, demo_cap7, and demo-no-location.
  • Shared setup succeeds for both full demos with sync isolated; repeated packing preserves the stable tarball inode/hash when bytes are unchanged, and both per-demo stamps equal the tarball hash.
  • Full repository vp check has an unchanged baseline README.md formatting failure; the combined diff does not modify that generated file.

Affected code checklist

  • Notifications
  • Outcomes
  • REST API requests
  • Public API changes

Checklist

  • I have filled out all required sections
  • PR contains the related SDK-5125 cleanup
  • No public API changes
  • Automated tests pass
  • Diff reviewed

cursoragent and others added 8 commits September 1, 2026 21:52
Co-authored-by: Fadi George <fadi-george@users.noreply.github.com>
Co-authored-by: Fadi George <fadi-george@users.noreply.github.com>
Co-authored-by: Fadi George <fadi-george@users.noreply.github.com>
Co-authored-by: Fadi George <fadi-george@users.noreply.github.com>
Co-authored-by: Fadi George <fadi-george@users.noreply.github.com>
Co-authored-by: Fadi George <fadi-george@users.noreply.github.com>
Co-authored-by: Fadi George <fadi-george@users.noreply.github.com>
Co-authored-by: Fadi George <fadi-george@users.noreply.github.com>
@onesignal-deploy
onesignal-deploy requested a review from a team September 1, 2026 22:02
@fadi-george fadi-george changed the title fix: complete TypeScript wrapper cleanup chore: complete TypeScript wrapper cleanup Sep 2, 2026
@fadi-george
fadi-george merged commit f94dadb into main Sep 2, 2026
11 checks passed
@fadi-george
fadi-george deleted the fadi/SDK-5125 branch September 2, 2026 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants