Skip to content

feat: [SDK-5128] add explicit Android notification grouping to demos #2730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
onesignal-deploy wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −1
Open

feat: [SDK-5128] add explicit Android notification grouping to demos #2730

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions examples/demo/GettingStarted.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,13 @@ Fire test notifications from the device via the OneSignal REST API:
- **With Image** — includes a big picture
- **Custom** — fully customizable title, body, and additional data

All demo sends use the same explicit Android group (`demo-group`). Send two
notifications to verify that OneSignal creates and manages the notification
summary instead of relying on Android system auto-grouping. Verifying that
tapping the summary supplies OneSignal notification click data requires testing
on an Android device or emulator; the REST payload alone cannot verify tap
behavior.

### In-App Messaging
**Pause / resume** in-app message display.

Expand Down
4 changes: 3 additions & 1 deletion examples/demo/app/src/main/java/com/onesignal/example/data/network/OneSignalService.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ object OneSignalService {
private const val TAG = "OneSignalService"
private const val ONESIGNAL_API_URL = "https://onesignal.com/api/v1/notifications"
private const val ONESIGNAL_API_BASE_URL = "https://api.onesignal.com"
private const val DEMO_ANDROID_GROUP = "demo-group"

private var appId: String = ""

Expand Down Expand Up @@ -57,7 +58,7 @@ object OneSignalService {
put("include_subscription_ids", org.json.JSONArray().put(subscriptionId))
put("headings", JSONObject().put("en", type.notificationTitle))
put("contents", JSONObject().put("en", type.notificationBody))
put("android_group", type.title)
put("android_group", DEMO_ANDROID_GROUP)
put("android_led_color", "FF595CF2")
put("android_accent_color", "FF595CF2")
type.largeIcon?.let {
Expand Down Expand Up @@ -107,6 +108,7 @@ object OneSignalService {
put("include_subscription_ids", org.json.JSONArray().put(subscriptionId))
put("headings", JSONObject().put("en", title))
put("contents", JSONObject().put("en", body))
put("android_group", DEMO_ANDROID_GROUP)
put("android_led_color", "FF595CF2")
put("android_accent_color", "FF595CF2")
}
Expand Down