Skip to content

fix: R8 AutoValue suppressions + Huawei release in CI #2592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abdulraqeeb33 merged 1 commit into from
Mar 24, 2026
Merged

fix: R8 AutoValue suppressions + Huawei release in CI #2592

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,10 @@ jobs:
working-directory: OneSignalSDK
run: |
./gradlew testDebugUnitTest --console=plain --continue
- name: "[Build] Demo app (minified release)"
- name: "[Build] Demo app (minified GMS + Huawei release)"
working-directory: OneSignalSDK
run: |
./gradlew :app:assembleGmsRelease --console=plain
./gradlew :app:assembleGmsRelease :app:assembleHuaweiRelease --console=plain
Comment on lines +44 to +47
Copy link

Copilot AI Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The demo app conditionally applies either com.google.gms.google-services or com.huawei.agconnect based on gradle.startParameter.taskRequests (it uses an if (...) { } else if (...) { }), so invoking :app:assembleGmsRelease and :app:assembleHuaweiRelease in the same Gradle run will only apply the first-matched plugin (likely google-services). That can cause the Huawei release build to be built without the intended Huawei plugin/config, or fail depending on the build. Consider running these as two separate Gradle invocations (or separate steps), so each build config is exercised with the correct plugin applied.

Copilot uses AI. Check for mistakes.
- name: "[Diff Coverage] Check for bypass"
id: coverage_bypass
if: github.event_name == 'pull_request' || github.event_name == 'workflow_dispatch'
Expand Down
5 changes: 5 additions & 0 deletions OneSignalSDK/onesignal/otel/consumer-rules.pro
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
# OpenTelemetry OTLP exporter references Jackson core classes that are optional on Android.
# Suppress R8 missing-class errors when apps don't include jackson-core.
-dontwarn com.fasterxml.jackson.core.**

# OTel / disk buffering reference Google Auto Value types that are not on the app classpath.
-dontwarn com.google.auto.value.AutoValue
-dontwarn com.google.auto.value.AutoValue$Builder
-dontwarn com.google.auto.value.AutoValue$CopyAnnotations
4 changes: 3 additions & 1 deletion examples/demo/app/proguard-rules.pro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,9 @@
# hide the original source file name.
#-renamesourcefileattribute SourceFile

# Demo-only suppression for optional OTel transitive classes.
# Demo-only: optional transitive classes pulled in via OneSignal OTel / R8 (GMS + Huawei minified builds).
-dontwarn com.fasterxml.jackson.core.JsonFactory
-dontwarn com.fasterxml.jackson.core.JsonGenerator
-dontwarn com.google.auto.value.AutoValue
-dontwarn com.google.auto.value.AutoValue$Builder
-dontwarn com.google.auto.value.AutoValue$CopyAnnotations
Loading