[wpmlpb-824] Divi: translate contact-field conditional-logic and select-options#536
Merged
Conversation
…+ select options)
Contact form fields with conditional logic ("show if Field = Value") stopped
working on translated pages: the option labels were translated but the rule's
compared value was not, so Divi's strict string match ("is") no longer
succeeded and the dependent field never showed.
Register the conditionalLogic rule values so both the option and the rule
translate to the same string (they share one WPML string, so they cannot
diverge) and the match holds after translation. Also add the previously
missing selectOptions, so select-field options translate too -- otherwise
translating a select-based rule value would newly break the match.
https://onthegosystems.myjetbrains.com/youtrack/issue/wpmlpb-824/
Co-authored-by: Chai <david.gw@onthegosystems.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contact form fields with conditional logic ("show if Field = Value") stopped working on translated pages: the option labels were translated but the rule's compared value was not, so Divi's strict string match ("is") no longer succeeded and the dependent field never showed.
Register the conditionalLogic rule values so both the option and the rule translate to the same string (they share one WPML string, so they cannot diverge) and the match holds after translation. Also add the previously missing selectOptions, so select-field options translate too -- otherwise translating a select-based rule value would newly break the match.
https://onthegosystems.myjetbrains.com/youtrack/issue/wpmlpb-824/