[wpmlpb-863] Divi: make media-url keys explicit until WPML 5 is widely adopted#535
Merged
Conversation
…ML-5 Expand the screen-size * wildcard to explicit desktop/tablet/phone for the 13 Divi media-url keys: background images (divi, divi/counter, divi/contact-form, divi/post-nav, divi/search, divi/signup, divi/fullwidth-header) and image/logo srcs (divi, divi/slide, divi/svg, divi/team-member, divi/fullwidth-header). media-url/media-ids under a * only resolves with the media path-walker wildcard support that ships in WPML 5.0 (wpmlpb-828); on older WPML these images translate via neither the media walker nor string-extraction. Explicit responsive keys work on all versions, so this deploys now. String/link keys under * are unaffected. Collapsing back to * once WPML 5.0 adoption is high is tracked in wpmlpb-861. https://onthegosystems.myjetbrains.com/youtrack/issue/wpmlpb-863/ Co-authored-by: Chai <david.gw@onthegosystems.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expand the screen-size * wildcard to explicit desktop/tablet/phone for the 13 Divi media-url keys: background images (divi, divi/counter, divi/contact-form, divi/post-nav, divi/search, divi/signup, divi/fullwidth-header) and image/logo srcs (divi, divi/slide, divi/svg, divi/team-member, divi/fullwidth-header).
media-url/media-ids under a * only resolves in WPML 5.0 (wpmlpb-828);
Collapsing back to * once WPML 5.0 adoption is high is tracked in wpmlpb-861.
https://onthegosystems.myjetbrains.com/youtrack/issue/wpmlpb-863