[wpmlpb-857] divi/menu: capture rendered logo title/alt from decoration#534
Merged
Conversation
Collaborator
Author
|
The attributes array is indexed based, I cannot target alt/title attributes directly, but its ok because:
|
Divi renders the menu logo title/alt from the module decoration attributes (targetElement="logo"), but the config only captured the non-rendered logo>innerContent alt/titleText copies - so translating them had no front-end effect. Add the module>decoration>attributes>* capture (as divi/image already has) and drop the dead logo>innerContent alt/titleText. Verified on the local site: the decoration title/alt now register as translatable strings; the innerContent copies no longer do. String-based (no wildcard-media dependency), ships with WPML 5. https://onthegosystems.myjetbrains.com/youtrack/issue/wpmlpb-857/ Co-authored-by: Chai <david.gw@onthegosystems.com>
dgwatkins
force-pushed
the
agent/wpmlpb-857
branch
from
b3f468c to
89a2c17
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Divi renders the menu logo title/alt from the module decoration attributes (targetElement="logo"), but the config only captured the non-rendered logo>innerContent alt/titleText copies - so translating them had no front-end effect. Add the module>decoration>attributes>* capture (as divi/image already has) and drop the dead logo>innerContent alt/titleText.
https://onthegosystems.myjetbrains.com/youtrack/issue/wpmlpb-857/