Open
Conversation
Set up continuous integration with four parallel jobs: - Lint (ESLint + Prettier format check) - Type check (TypeScript strict) - Build (full Turborepo build) - Test (with PostgreSQL pgvector/pg17 and Redis service containers) Uses pnpm 9, Node.js 22, and concurrency groups with cancel-in-progress to avoid redundant runs on rapid pushes.
Jenish-1235
reviewed
Feb 21, 2026
Jenish-1235
reviewed
Feb 21, 2026
Jenish-1235
reviewed
Feb 21, 2026
Jenish-1235
reviewed
Feb 21, 2026
Jenish-1235
reviewed
Feb 21, 2026
Lint and typecheck run in parallel first. Test (which already runs pnpm build internally) only starts if both pass, avoiding wasted compute on code that fails basic checks.
Jenish-1235
reviewed
Feb 21, 2026
Jenish-1235
reviewed
Feb 21, 2026
Jenish-1235
requested changes
Feb 21, 2026
Jenish-1235
reviewed
Feb 21, 2026
Jenish-1235
requested changes
Feb 21, 2026
Merge queue is now enabled on main via rulesets. CI runs on pull_request and merge_group events. The push trigger is no longer needed since merge queue tests the merge result before merging to main.
Jenish-1235
reviewed
Feb 21, 2026
Jenish-1235
requested changes
Feb 21, 2026
CI: add 85% test coverage thresholds via vitest configs, diff coverage check on changed lines using diff-cover, merge_group trigger for merge queue, staged jobs with needs. CD: build and push Docker images (api + dashboard) to GHCR on merge to main. Multi-stage Dockerfiles using pnpm deploy for api and Next.js standalone output for dashboard.
Jenish-1235
reviewed
Feb 21, 2026
Jenish-1235
reviewed
Feb 21, 2026
Pipes diff-cover output to a report file and uploads all per-package coverage directories, merged lcov, and diff-cover report as downloadable artifacts. Retained for 30 days.
pnpm/action-setup@v4 conflicts when both version key in workflow and packageManager field in package.json are set. Removed explicit version so it reads pnpm@9.15.4 from packageManager automatically.
checkout v4 -> v6, setup-node v4 -> v6, upload-artifact v4 -> v6
next lint auto-adds allowJs and .next/types/**/*.ts to tsconfig.json, which then causes format:check to fail on the modified file. Adding these values upfront prevents the runtime modification.
Jenish-1235
reviewed
Feb 21, 2026
| contents: read | ||
| packages: write | ||
|
|
||
| jobs: |
Member
There was a problem hiding this comment.
if api and dashboard is separate concerns, then why are we running cd job for both everytime ? Any alternative approach ?
Member
|
@Sauhard74 test job failing due to minimum 85 percent coverage. Let's allow failure true for now. Once this PR merges, would request the first step to be taken as adding tests for pending code and then resetting to allow failure false before pushing other feature changes. |
Member
|
or else remove the merge queue for now, hence we can add test from other PRs and then we will reenable here and merge this CI CD later. |
Coverage thresholds will be added per-package alongside their test files in subsequent PRs. passWithNoTests prevents vitest from failing when no test files exist yet.
- Add 85% coverage thresholds (lines/functions/branches/statements) to all vitest configs - Add tests for core/config.ts: normalizeRankingWeights, validateStalenessConfig - Add tests for core/constants.ts: value assertions, weight sum invariant, staleness ordering - Exclude scaffold server.ts from api coverage (rewritten in PR #5)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TRD Phase 1 Deliverable
CI/CD pipeline (GitHub Actions: lint, type-check, test, build)Test plan