Skip to content

Implement Bulk Operations in WebAPI#2455

Open
Sreejithpin wants to merge 486 commits into
OData:masterfrom
Sreejithpin:BulkOperations8
Open

Implement Bulk Operations in WebAPI#2455
Sreejithpin wants to merge 486 commits into
OData:masterfrom
Sreejithpin:BulkOperations8

Conversation

@Sreejithpin

Copy link
Copy Markdown
Contributor

Issues

Implements Bulk Operation in webAPI

Description

  • Implements Bulk Operation
  • Deserialization
  • Patching
  • Nested Patching
  • DataModification Exception

Briefly describe the changes of this pull request.

Checklist (Uncheck if it is not completed)

  • Test cases added
  • Build and test with one-click build and test script passed

Additional work necessary

If documentation update is needed, please add "Docs Needed" label to the issue and provide details about the required document change in the issue.

xuzhg and others added 30 commits July 6, 2018 10:55
* downgrade the newtonsoft.json version to 6.0.4 for classic

* change the newtonsoft.json version in classic test
 (OData#1560)

* Don't assume port 80 when generating nextLink in ASP.NET Core OData#1559

If the port isn't set on `request.Host`, port 80 was assumed previously.
If the app is running behind a reverse proxy, and the port was not forwarded,
this can result in invalid URLs - for example an https URL using port 80
Instead, we just omit the port completely if it's not explictly set.

* Add unit tests for GetNextPageLink

* Add copyright notice
…#1588)

- Null check on ODataQueryParameterBindingAttribute for Net Core
This is a regression from 5.x to 6.x/7.x. It looks like the original fix was
never merged to the 6.0 development branch.

Issue: OData#736
- Add comma before MyLevel property.
This is addresses the unhelpful error message described in this GitHub issue:

OData#1421
Improving the error message for when an unknown property is deserialized
@Sreejithpin

Copy link
Copy Markdown
Contributor Author
    internal IEdmTypeReference GetEdmType(object instance, Type type)

We can throw an exception if its null, which would change the current behaviour, but i guess thats fine right


In reply to: 828778014


Refers to: src/Microsoft.AspNet.OData.Shared/Formatter/Serialization/ODataSerializerContext.cs:290 in ab656df. [](commit_id = ab656df, deletion_comment = False)

davidfowl and others added 2 commits May 12, 2021 09:57
- This was caught when moving ServiceCollection to another assembly (type forwarded).
@Sreejithpin

Copy link
Copy Markdown
Contributor Author
    internal IEdmTypeReference GetEdmType(object instance, Type type)

we have a type mapping cache already right


In reply to: 828777381


Refers to: src/Microsoft.AspNet.OData.Shared/Formatter/Serialization/ODataSerializerContext.cs:290 in ab656df. [](commit_id = ab656df, deletion_comment = False)

KenitoInc and others added 19 commits May 21, 2021 09:54
* BulkInsert1 draft

* Bulk insert changes

* deleted old test

* updates

* Update ODataResourceSetWrapper.cs

* updates

* Updated addressing  comments

* updates

* updates

updates

* Updates

* Updates

* Minor updates

* comments

* updates

* update publicapi for core

* Address comments

* Cleanup and additional tests

Cleanup and additional tests

* Updated code

* BulkInsert1 draft

* Bulk insert changes

* deleted old test

* updates

* updates

* Updated addressing  comments

* updates

* updates

updates

* Updates

* Updates

* Minor updates

* updates

* Address comments

* Cleanup and additional tests

Cleanup and additional tests

* DataAnnotationException updates

* comments

* small updates

* updates

* small update

* updates

* Updates

* Update DeltaSetOfT.cs

* Updates with Patch

* updates

* updates

* Update WebHostTestFixture.cs

* updates

* Update DeltaOfTStructuralType.cs

* Updates

* Updates for serializer etc

* Update WebHostTestFixture.cs

* updates

* updates

* updates

* Bulk Operations Updates
@pull-request-quantifier-deprecated

Copy link
Copy Markdown

This PR has 3935 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +3582 -353
Percentile : 100%

Total files changed: 86

Change summary by file extension:
.csproj : +48 -4
.config : +95 -84
.cs : +3111 -241
.resx : +18 -0
.projitems : +16 -0
.bsl : +294 -24

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detetcted.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@xuzhg xuzhg force-pushed the master branch 2 times, most recently from 4c43a84 to ddfd3dd Compare May 29, 2026 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.